Reporting this against Drupal 4.6.3, because that's where I found it, but the bug also exists in current CVS head (revision 1.555) of node.module.

The RSS feed's XML unconditionally appends a hyphen to the site title, even when there is no site slogan to follow the hyphen. This was reported in http://drupal.org/node/38975. Christian Berg tracked down the cause of the bug, and I wrote the attached patch. There's also a log message in the patch file.

I believe this is ready to commit, but since I'm new here, I've marked this issue as "patch (code needs review)".

Thanks,
-Karl Fogel

CommentFileSizeAuthor
#1 title-hyphen-patch_0.txt1.05 KBkfogel
title-hyphen-patch.txt1.08 KBkfogel

Comments

kfogel’s picture

kfogel commented
StatusFileSize
new title-hyphen-patch_0.txt1.05 KB
kfogel’s picture

kfogel commented

Please use the second attachment, http://drupal.org/files/issues/title-hyphen-patch_0.txt. The code is slightly cleaner.

kfogel’s picture

kfogel commented
Status: Needs review » Reviewed & tested by the community

I've confirmed that this bug is still present in revision 1.640. You can see it via ViewCVS in:

http://cvs.drupal.org/viewcvs/drupal/drupal/modules/node.module?rev=1.64...

or check it out directly from CVS:

$ cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal checkout drupal
$ cd drupal/modules
$ grep -C2 "channel_defaults = array" node.module

The fix in http://drupal.org/files/issues/title-hyphen-patch_0.txt is still applicable, as far as I can tell.

I've changed this issue's status to "patch (ready to be committed)". I hope that was the right thing
to do. For a very long time it was "patch (code needs review)"... I don't know if it ever got reviewed,
but it's such a simple patch that, IMHO, it is safe to call it "ready to be committed".

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to DRUPAL-4-6.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)