theme.inc has three remaining functions and a few constants.
We should be able to convert them to better locations.
Open theme.inc
Move drupal_find_theme_templates to TemplateFinder::scan
Inline theme_settings_convert_to_config
Move theme_get_suggestions to ThemeSuggestions:get We could also inline this and rework the tests, but I did see some contrib usage, and it reads like it's meant to be api.
Review
Confirm test changes
Create follow up for responsive constants
N/A
N/A
N/A
N/A
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
nicxvan commentedComment #4
nicxvan commentedComment #5
nicxvan commentedI'll work on the CR now.
Comment #6
nicxvan commentedComment #7
nicxvan commentedComment #8
smustgrave commented@nicxvan asked for a review of this.
Applied the MR locally
Searched for drupal_find_theme_templates and all instances are replaced.
Same for theme_settings_convert_to_config and theme_get_suggestions
Am moving to NW though as the CR may have a typo? Says theme_get_suggestions is replaced by \Drupal::service(ThemeSuggestions::class)->get() and \Drupal::service(TemplateFinder::class)->scan()
If drupal_find_theme_templates suppose to be in the first before?
other then that everything looks good!
Comment #9
nicxvan commentedThanks! I fixed the typo in the cr!
Comment #10
smustgrave commentedThanks for fixing!