Deprecate MARK_* and RESPONSIVE_PRIORITY_* constants

the constants are passed to the mark template. They are defined by it and that's why they are in theme.inc. both node and history module are just using them, not owning them.

That makes BC really challenging with an enum and moving it, we'd need completely deprecate and replace the theme hook, but that would break anyone using it.

Am I missing something or is this still true?

I only see:

      'mark' => [
        'variables' => [
          'status' => MARK_NEW,
        ],
      ],

Then direct checks in the template.

No you're right, we're still defining the 'mark' theme hook in ThemeCommonElements.

I think we need an issue against history module to move the theme hook over there (where it could use an enum if it wants), and we could keep this for deprecating the constants and theme hook. Going to be for removal in Drupal 13 at this point.

Not sure if the responsive constants ended up in the right place.

Failures look random, they passed on the previous run.

@nicxcan posted about this in #needs-review-queue channel so decided to give it a look.

First nice find that it was no longer used!

Pretty basic review.
I applied the MR locally
Did searches for RESPONSIVE_PRIORITY_MEDIUM (25 matches) and RESPONSIVE_PRIORITY_LOW (28 matches) and just verified they were using Table:: now and the ones that weren't were around the deprecation

Did the same for MARK_READ but found some twig template mark.html.twig

Assume these templates need to be deprecated as well?

The templates are deprecated by the hook, I asked @catch about the process yesterday on slack but forgot to mention it.

The theme hook deprecation will trigger for the templates.

Could we add a todo in the template so it’ll get picked up when we searches deprecations. Just afraid in a few years may forget

Thanks!