Problem/Motivation

#3037202: Remove drupal_static() from node_mark() showed that node_mark() is only used for the non-view version of node admin listings. It is very tangled up with history module.

Steps to reproduce

Proposed resolution

Deprecate it for removal. The non-views fallback for node admin listings would need to no longer user the mark functionality.

Remaining tasks

Decide what to do with the template.

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3223211

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

acbramley made their first commit to this issue’s fork.

acbramley opened merge request !11541

acbramley’s picture

acbramley commented
Status: Active » Needs review

Created #3514191: Move MARK_* constants from theme.inc into Enum in History module as well now that the history module is the only user of these constants.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems pretty straightforward and deprecation appears correct.

  • catch committed 4a2232d1 on 11.x 
    Issue #3223211 by acbramley, catch: Deprecate node_mark
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

I opened the issue long enough ago that I'd forgotten about the list builder comment in the issue summary so had to think it through again. I think it's fine for that to not have the soft dependency on history module, views provides the more full-featured version now.

Committed/pushed to 11.x, thanks!

catch closed merge request !11541

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

acbramley’s picture

acbramley commented
Parent issue: » #3532197: [meta] Deprecate node.module functions