Problem/Motivation
node.module contains many old school procedural functions, many of which are no longer used by core or are better replaced by already existing OO code.
Some of these can be moved to hooks classes, or some may need replacements. This meta will track all the work to deprecate these functions.
Functions
1. node_title_list
#3531953: Deprecate node_title_list
2. node_mark
#3223211: Deprecate node_mark
3. node_type_get_names
#3534587: Deprecate node_type_get_names
4. node_get_type_label
#3531943: Deprecate node_get_type_label()
5. node_type_get_description
#3531944: Deprecate node_type_get_description
6. node_add_body_field
#3489266: Deprecate node_add_body_field()
7. node_is_page
#3458589: Deprecate $variables['page'] for node.html.twig and node_is_page()
8. node_access_view_all_nodes
#3038908: Deprecate node_access_view_all_nodes()
9. node_access_needs_rebuild, node_access_rebuild, _node_access_rebuild_batch_operation, _node_access_rebuild_batch_finished
#3533299: Deprecate node access rebuild functions
10. node_reindex_node_search
#3533612: Deprecate node_reindex_node_search() and move reindexing logic to a hook
11. node_access_grants
#2473041: Restructure node access grant behavior into the node access handler
The following functions are hooks that will be handled separately:
template_preprocess_node_add_list, node_preprocess_html, node_preprocess_block, node_theme_suggestions_node, template_preprocess_node
#3532204: Move preprocess functions into NodeThemeHooks
node_form_system_themes_admin_form_submit
#3532200: Consolidate formSystemThemesAdminFormAlter and submit callback into NodeFormHooks
Comments
Comment #2
acbramley commentedComment #3
acbramley commentedComment #4
acbramley commentedComment #5
acbramley commentedComment #6
acbramley commentedComment #7
acbramley commentedComment #8
acbramley commentedComment #9
acbramley commentedComment #10
acbramley commentedComment #12
nicxvan commented