Problem/Motivation

We should ship 11.5.0 with the latest versions of our PHP dependencies.

Steps to reproduce

Proposed resolution

composer update

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3627487-nr-bot_5fwhl0xy.txt631 bytesneeds-review-queue-bot

Issue fork drupal-3627487

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !17316

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

MR created with

composer update --with=guzzlehttp/guzzle:^7

Lock diff:

+------------------------------------+------------+----------+
| Production Changes                 | From       | To       |
+------------------------------------+------------+----------+
| composer/semver                    | 3.4.4      | 3.5.0    |
| doctrine/lexer                     | 3.0.1      | 3.0.3    |
| justinrainbow/json-schema          | 6.8.2      | 6.13.1   |
| masterminds/html5                  | 2.10.0     | 2.11.0   |
| mck89/peast                        | v1.17.6    | v1.18.1  |
| pear/archive_tar                   | 1.6.0      | 1.6.1    |
| php-tuf/composer-stager            | v2.1.0     | v2.1.1   |
| symfony/console                    | v7.4.13    | v7.4.20  |
| symfony/dependency-injection       | v7.4.13    | v7.4.20  |
| symfony/error-handler              | v7.4.8     | v7.4.20  |
| symfony/event-dispatcher           | v7.4.9     | v7.4.17  |
| symfony/event-dispatcher-contracts | v3.7.0     | v3.7.1   |
| symfony/filesystem                 | v7.4.11    | v7.4.18  |
| symfony/finder                     | v7.4.8     | v7.4.20  |
| symfony/http-foundation            | v7.4.13    | v7.4.20  |
| symfony/http-kernel                | v7.4.13    | v7.4.20  |
| symfony/mailer                     | v7.4.12    | v7.4.19  |
| symfony/mime                       | v7.4.13    | v7.4.19  |
| symfony/polyfill-iconv             | v1.37.0    | v1.43.0  |
| symfony/polyfill-intl-grapheme     | v1.38.1    | v1.43.0  |
| symfony/polyfill-intl-idn          | v1.38.1    | v1.43.0  |
| symfony/polyfill-intl-normalizer   | v1.38.0    | v1.43.0  |
| symfony/polyfill-mbstring          | v1.38.1    | v1.43.0  |
| symfony/polyfill-php84             | v1.38.1    | v1.43.0  |
| symfony/polyfill-php85             | v1.38.1    | v1.43.0  |
| symfony/polyfill-php86             | v1.38.0    | v1.43.0  |
| symfony/process                    | v7.4.13    | v7.4.19  |
| symfony/routing                    | v7.4.13    | v7.4.20  |
| symfony/runtime                    | v7.4.13    | v7.4.14  |
| symfony/serializer                 | v7.4.10    | v7.4.20  |
| symfony/service-contracts          | v3.7.0     | v3.7.3   |
| symfony/string                     | v7.4.13    | v7.4.19  |
| symfony/translation-contracts      | v3.7.0     | v3.7.1   |
| symfony/validator                  | v7.4.10    | v7.4.20  |
| symfony/var-dumper                 | v7.4.8     | v7.4.18  |
| symfony/var-exporter               | v7.4.9     | v7.4.18  |
| symfony/yaml                       | v7.4.15    | v7.4.20  |
| twig/html-extra                    | v3.24.0    | v3.29.0  |
| twig/twig                          | v3.28.0    | v3.30.0  |
+------------------------------------+------------+----------+

+-----------------------------------+---------+---------+
| Dev Changes                       | From    | To      |
+-----------------------------------+---------+---------+
| brick/math                        | 0.14.8  | 1.0.0   |
| composer/ca-bundle                | 1.5.12  | 1.5.14  |
| composer/class-map-generator      | 1.7.3   | 1.8.0   |
| composer/metadata-minifier        | 1.0.0   | 1.0.1   |
| composer/pcre                     | 3.3.2   | 3.4.0   |
| google/protobuf                   | v4.33.6 | v5.36.2 |
| mglaman/phpstan-drupal            | 2.2.1   | 2.2.2   |
| myclabs/deep-copy                 | 1.13.4  | 1.14.0  |
| nikic/php-parser                  | v5.7.0  | v5.9.0  |
| open-telemetry/api                | 1.9.0   | 1.10.0  |
| open-telemetry/gen-otlp-protobuf  | 1.9.0   | 1.10.0  |
| open-telemetry/sdk                | 1.14.0  | 1.15.0  |
| open-telemetry/sem-conv           | 1.38.0  | 1.44.0  |
| phpdocumentor/reflection-common   | 2.2.0   | 2.2.1   |
| phpdocumentor/type-resolver       | 2.0.0   | 2.1.0   |
| phpstan/phpdoc-parser             | 2.3.3   | 2.3.6   |
| phpstan/phpstan                   | 2.2.14  | 2.2.16  |
| phpstan/phpstan-deprecation-rules | 2.0.4   | 2.0.5   |
| phpstan/phpstan-phpunit           | 2.0.16  | 2.0.21  |
| phpunit/phpunit                   | 11.5.55 | 11.5.56 |
| ramsey/uuid                       | 4.9.2   | 4.9.4   |
| seld/jsonlint                     | 1.11.0  | 1.12.1  |
| seld/phar-utils                   | 1.2.1   | 1.2.3   |
| symfony/browser-kit               | v7.4.8  | v7.4.17 |
| symfony/css-selector              | v7.4.9  | v7.4.18 |
| symfony/dom-crawler               | v7.4.12 | v7.4.17 |
| symfony/lock                      | v7.4.9  | v7.4.20 |
| vincentlanglet/twig-cs-fixer      | 4.0.0   | 4.1.1   |
| webmozart/assert                  | 2.4.0   | 2.4.1   |
+-----------------------------------+---------+---------+
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3627487-nr-bot_5fwhl0xy.txt631 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

godotislate’s picture

godotislate
he/him
commented

Not sure why the bot is saying there's a PHPCS issue, but there is a test failure for a deprecation.

1) /builds/project/drupal/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:51
    Since twig/twig 3.29: Not passing a value for the "default_admin_is_sticky" argument of macro "table_header" is deprecated and the argument will be required in Twig 4.0; give it a default value in the macro definition or pass a value when calling it (in "core/themes/default_admin/templates/views/views-view-table.html.twig" at line 109).

longwave-bot made their first commit to this issue’s fork.

godotislate’s picture

godotislate
he/him
commented

Re #5 Realized we're going to have the same deprecation warning on main and 12.0.x when we update those branches to Twig 3.29+, so maybe we should do that template fix in a separate issue for main, 12.0.x, 11.x, and 11.5.x first?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Yes that's a good idea. We can still do this issue by excluding Twig if we need to.

godotislate’s picture

godotislate
he/him
commented

Opened #3631208: Explicitly set Twig macro argument value in views-view-table.html.twig.