Problem/Motivation

It's been pointed out a few times over the years, not sure why it's not been done, but we should just rename them.

Steps to reproduce

Open core/scripts

Proposed resolution

  • password-hash.sh*
  • rebuild_token_calculator.sh*
  • run-tests.sh*
  • update-countries.sh*

Rename any callers

Remaining tasks

Review

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3626003-nr-bot_udoy1nw5.txt1.03 KBneeds-review-queue-bot

Issue fork drupal-3626003

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Issue summary: View changes

nicxvan opened merge request !17247

nicxvan’s picture

nicxvan commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Instead of renaming them can we convert them to CLI commands?

run-tests.sh is likely the most problematic as it will be used in CI pipelines. The others we should investigate if they are still useful in Drupal 12 and beyond.

nicxvan’s picture

nicxvan commented

Can't those be follow ups? This is a relatively minor change and those follow ups will likely take some time.

I don't recall ever having to use password hash or update countries.

But I did have to use rebuild and the token calculator a few months ago to bisect across the 11.4 change without blowing the db away and reinstalling.

nicxvan’s picture

nicxvan commented
Status: Active » Needs review
nicxvan’s picture

nicxvan commented
Issue summary: View changes
mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +run-tests.sh
mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3595595: Convert run-tests.sh to a set of dr commands
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I don't think we should do this for run-tests.sh without providing some kind of backward compatibility, unless maybe we do in Drupal 12 only and before rc1. But that might be annoying for people who run tests on both majors!

nicxvan’s picture

nicxvan commented

I'm ok with 12 only, can the templates handle that? E.g if it's a 12.x test it uses .php, if it's 11.x it uses .sh?

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3626003-nr-bot_udoy1nw5.txt1.03 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.