Needs work
Project:
Drupal core
Version:
main
Component:
routing system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Aug 2026 at 22:53 UTC
Updated:
4 Sep 2026 at 10:16 UTC
Jump to comment: Most recent, Most recent file
Show commands
changes
Comments
Comment #4
longwaveUnsure if this is too big to review, let's see.
While I was here I decided to remove all titles that weren't explicitly tested, I don't see the point in carrying all those around.
This MR was generated by an LLM.
Comment #5
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #6
longwaveComment #7
mstrelan commentedThis is indeed long, but it's mostly the same pattern, and in most cases the yaml file appears near the class in the MR.
It occurred to me that we should have a more ergonomic way to do this:
requirements: ['_access' => 'TRUE']but I'm not sure what would be most appropriate.I commented on a few places that I thought we were able to use the title arg to pass a callback, but maybe I've mis-remembered how that works. Setting NW but please set back if we can't actually do that.
Comment #8
mstrelan commentedAnd one more question - if there is no title, and the controller doesn't return a title either, are there any warnings or notices?
Comment #9
longwaveThe
\dconversion looks correct to me, I think there would be a test failure otherwise.We can't backport the title callbacks to 11.x, so maybe we should do that in #3615108: Move _title and _title_callback out of defaults section in existing route attributes? Same for improving boolean requirements which has an issue already: #2726519: Leverage improved DX in route requirements
If there is no title then you just get an empty title on the page.
Comment #10
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.