Problem/Motivation

The vertical tabs styles got broken. Looks like this happened with commits f9ba80d9c2c & e9065446e20.

Some of the color combinations fail WCAG SC 1.4.3 Contrast (Minimum) (Level AA).

Screenshots of the vertical tabs at /admin/config/people/accounts in dark and light mode, for commits f9ba80d9c2c and f219bd6e6cd, respectively:

Dark mode, @9fc2acb5869:

Dark mode, @f219bd6e6cd:

Light mode, @9fc2acb5869:

Light mode, @f219bd6e6cd:

Steps to reproduce

  1. Set admin theme to Default Admin.
  2. Go to /admin/config/people/accounts.
  3. Observe the vertical tabs in the Emails section at the bottom of the form in both light & dark modes.
Differences

On a higher level, it looks like a lot of Claro styles are currently in effect.

  1. Side border color for active item.
    In dark mode, this is a WCAG color contrast failure (contrast is 1.74:1)
  2. Dark mode border colors.
  3. Border radii.

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Comments

kentr created an issue. See original summary.

kentr’s picture

kentr’s picture

Status: Needs work » Active
mherchel’s picture

Status: Active » Postponed (maintainer needs more info)
StatusFileSize
new99.19 KB
new98.02 KB

I believe this was fixed in #3606571: Round 2 of consolidating CSS Variables . Can you double check?

Here's the current main branch.


kentr’s picture

Status: Postponed (maintainer needs more info) » Closed (outdated)

Active item border color appears to be fixed.

Summarizing our Slack discussion regarding the other points in the issue summary:

It's intentional that some of the styling is Claro instead of the original Default Admin, because it matches the current verstion of Gin. This version looks different than the version that was merged into core.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.