Problem/Motivation
The vertical tabs styles got broken. Looks like this happened with commits f9ba80d9c2c & e9065446e20.
Some of the color combinations fail WCAG SC 1.4.3 Contrast (Minimum) (Level AA).
Screenshots of the vertical tabs at /admin/config/people/accounts in dark and light mode, for commits f9ba80d9c2c and f219bd6e6cd, respectively:
Dark mode, @9fc2acb5869:

Dark mode, @f219bd6e6cd:

Light mode, @9fc2acb5869:

Light mode, @f219bd6e6cd:

Steps to reproduce
- Set admin theme to Default Admin.
- Go to
/admin/config/people/accounts. - Observe the vertical tabs in the Emails section at the bottom of the form in both light & dark modes.
Differences
On a higher level, it looks like a lot of Claro styles are currently in effect.
- Side border color for active item.
In dark mode, this is a WCAG color contrast failure (contrast is 1.74:1) - Dark mode border colors.
- Border radii.
Proposed resolution
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Account_settings___Drush_Site-Install-2.png | 98.02 KB | mherchel |
| #4 | Account_settings___Drush_Site-Install.png | 99.19 KB | mherchel |
| #2 | 3616351-2-light-mode-@9fc2acb5869.png | 105.63 KB | kentr |
| #2 | 3616351-2-dark-mode-@9fc2acb5869.png | 104.04 KB | kentr |
| #2 | 3616351-2-dark-mode-current.png | 105.14 KB | kentr |
Comments
Comment #2
kentr commentedComment #3
kentr commentedComment #4
mherchelI believe this was fixed in #3606571: Round 2 of consolidating CSS Variables . Can you double check?
Here's the current main branch.
Comment #5
kentr commentedActive item border color appears to be fixed.
Summarizing our Slack discussion regarding the other points in the issue summary:
It's intentional that some of the styling is Claro instead of the original Default Admin, because it matches the current verstion of Gin. This version looks different than the version that was merged into core.