Cleanup CSS files in migrate/css by moving them over to css, either adding missing pieces to existing files or by adding entire new files.
Note this will be a blocker for many issues, including most accessibility issues.
- #3582826: Untangle gin.css
- #3583057: Convert the compiled CSS in default_admin's components, layout, and theme to modern PostCSS
- #3582833: Consolidate, refactor, remove and untangle Claro's CSS from Default Admin theme
- Consolidate, merge, and refactor Gin's CSS variable's into Claro's original variables.
- Remove any
ginnamespacing from CSS classes and variables, including CSS selectors used in PHP and template files. - implement
box-sizing: border-boxon:rootelement - Attempt to simplify selectors where we can, and remove
!importantdeclarations where possible - Change focus outlines to use
outlineproperty instead ofbox-shadow - Remove CSS files that extend contrib modules. Open issues in the respective modules to move CSS there
- Why is default admin theme changing Navigation toolbar styles? Should it be? If so, move those styles to Navigation module
- Remove
ginfrom various namespaces in CSS and JS - Default Admin & Navigation both load the Inter font. This needs to be consolidated.
- Update CSS to use modern CSS (indentation, logical properties, et al)
- For sticky tables, Gin completely duplicates the table header element, and then stickies it. This is the old way. Claro at one point moved to just using position: sticky. We should do that
Comments
Comment #2
jurgenhaasComment #3
cilefen commentedComment #4
mhercheldefault_admin's CSS is a huge mess. IMO this should have been completed before it was merged into core. There will need to be many, many core commits (which introduce many delays).styles/basedirectory that get compiled into one file. This one file was committed to default_admin. It's > 5660 lines of CSS that needs to be untangled.styles/helpers/entiretyof Claro's CSS was copied over. This is because Gin used Claro as a base theme.Comment #5
mherchelOn the good news front, I created https://github.com/mherchel/ddev-drupal-admin-vrt, which is a DDEV add-on that sets up a visual-regression system, so we can easily test for regressions.
Comment #6
rkolleri just found this issue. looking at the issue summary and mikes comment, would it be preferable to wait with opening more issues until this issue is in? and that most of those bugs are potentially obsolete after cleanup? found #3576874: Toggle switches are visually broken within dialog modals a few weeks ago but also have a hand full of bugs in ios that would need issues as well.
Comment #7
catchThese should all be removed. We already removed support for forum, book etc. #3581831: Remove support for Book and Forum Module.
Comment #8
mherchelI say yeah. Even if the issues persist (which they may), they'll be blocked until we can get the CSS in a maintainable state.
Comment #9
mherchelComment #10
mherchelComment #11
mherchelComment #12
kentr commentedI'll postpone CSS-related accessibility issues based on this so that would-be contributors don't waste time on them.
Comment #13
kentr commentedRegarding
Gonna be a similar issue with
contextual_links.css, I think.AFAICT, both of them currently affect dark mode by way of custom properties defined in
variables.css.Comment #14
kentr commentedDisregard previous comment about
contextual_links.css. I conflated problems.Comment #15
mherchelComment #16
mherchelComment #17
mherchelComment #18
mherchelComment #19
mherchelComment #20
quietone commentedAnother issue completed.
Comment #21
mherchelComment #22
mherchelComment #23
mherchelComment #24
kentr commentedTweaked "5. Remove any
ginnamespacing from CSS classes and variables" in the IS to include CSS selectors in PHP and template files.