Problem/Motivation

#1945262: Introduce "before" and "after" for conditional ordering in library definitions changed the library definitions for Claro. As a result, the Claro Views UI actions list buttons look like unstyled buttons:

Steps to reproduce

Visit admin/structure/views/view/content on a Standard installation

Proposed resolution

Restore action list button stying in Claro

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

Claro Views UI actions list buttons look like actions list buttons

Introduced terminology

None

API changes

None

Data model changes

None

Release notes snippet

None

CommentFileSizeAuthor
claro-views-ui-actions-list-buttons.png55.16 KBidebr

Issue fork drupal-3616100

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

idebr created an issue. See original summary.

dbuzinov made their first commit to this issue’s fork.

dbuzinov changed the visibility of the branch 3616100-regression-claro-views to hidden.

dbuzinov changed the visibility of the branch 3616100-regression-claro-views to active.

dbuzinov changed the visibility of the branch 3616100-regression-claro-views to hidden.

dbuzinov’s picture

I’ve prepared a small fix for the Claro Views UI button spacing issue.

Summary:
This patch fixes the extra spacing in the Views UI action buttons in Claro by increasing the CSS specificity so it overrides the general .button styles.

The root cause was that the action button in the Views tab menu was inheriting the default button spacing from the generic .button styling, while the input-button variant used in the action list was not covered by the more specific selector. I updated the selector to target the specific Views UI button class and reset the margin/box shadow for the input variant.

Files changed:

views-ui.pcss.css
views-ui.css

What changed:
Added a more specific selector for .views-tabs__action-list-button.button
Added a dedicated rule for input.views-tabs__action-list-button.button
Reset margin-block and box-shadow so it matches the expected Claro button styling
This keeps the fix scoped to the Views UI action list without altering the global button styling used elsewhere.

Please review the patch and let me know if further adjustments are needed.

idebr’s picture

Status: Active » Needs work

The regression introduced in #1945262: Introduce "before" and "after" for conditional ordering in library definitions placed css/components/button.css after css/components/views-ui.css. Preferably the regression is fixed by restoring the previous file order for the smallest impact on subthemes

dbuzinov’s picture

Updated. The CSS workaround in views-ui.css and views-ui.pcss.css is removed, those files now match main.
The fix is a one-line change in claro.libraries.yml: css/components/button.css moves back to the component CSS category, from theme.
This restores button.css loading before views-ui.css, as it did before #1945262.

Closing my MR. Claro was removed from Drupal core starting with D12 (main), in #3584639. The fix here no longer applies to main, since the affected file no longer exists there.

dbuzinov’s picture

smustgrave’s picture

Version: main » 11.x-dev

As a recent regression this is still eligible to be fixed in core but claro is already removed in main. So 11.x is the only target here.

dbuzinov’s picture

Status: Needs work » Needs review