Problem/Motivation

#1945262: Introduce "before" and "after" for conditional ordering in library definitions changed the library definitions for Claro. As a result, the Claro Views UI actions list buttons look like unstyled buttons:

This is a ported issue from Core following Claro's move out of Drupal core into a contributed theme:
Duplicate/Predecessor Issue: #3616100: [regression] Claro Views UI actions list buttons look like unstyled buttons

Steps to reproduce

Visit admin/structure/views/view/content on a Standard installation with active Claro theme

Proposed resolution

Restore action list button stying in Claro

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

Claro Views UI actions list buttons look like actions list buttons

Introduced terminology

None

API changes

None

Data model changes

None

Release notes snippet

None

Issue fork claro-3624819

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dbuzinov created an issue. See original summary.

dbuzinov opened merge request !6

dbuzinov’s picture

dbuzinov commented
Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Thanks for picking, looking at the MR.

Definitely don't think removing button css from the global styling is the approach we want to take.

Also MR reads like AI please make sure to disclose use of AI

#3134107: Views UI dropbuttons overlap with headings may be related

smustgrave’s picture

smustgrave commented
Priority: Normal » Critical

Since it's removed from main already we need to fix both regression on 11.x and contrib.

smustgrave’s picture

smustgrave commented

Tested the MR and it does not fix the issue I'm seeing.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Actually it does, lets see if others agree on core/11.x

smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Needs work

Nope this causes a new issue in the dialog pane unfortunately.

dbuzinov’s picture

dbuzinov commented

Note re #4: The MR isn't removing buttons.css globally, just the duplicate entry in the "theme" section (item was in both "components" and "theme"). We might still need to tweak the file order

dbuzinov’s picture

dbuzinov commented
Status: Needs work » Needs review