Problem/Motivation

Now that #3565258: Support library-specific aggregates and #1945262: Introduce "before" and "after" for conditional ordering in library definitions have landed we should have more opportunities to improve aggregate hit rates.

Since Olivero and Claro are on their way out of core and default_admin's libraries are still in flux, concentrating on CSS shipped with core modules.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3615642-nr-bot_288uw9uk.txt91 bytesneeds-review-queue-bot
#6 3615642-nr-bot_amlmgz2u.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3615642

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !16623

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 changed the visibility of the branch main to hidden.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3615642-nr-bot_amlmgz2u.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Rebased.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

This should work as not sure how often the navigation css changes so this shouldn't randomly break :)

catch’s picture

catch
he/him
Primary language English
commented
Title: Add css_target to navigation libraries » Use aggregate_target for navigation libraries
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3615642-nr-bot_288uw9uk.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Rebased.