Problem/Motivation

One of the longest running performance tests, one method takes 70s so we can split that out.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3612987

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !16429

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward, catch is pretty good at these too so trust him on it.

godotislate’s picture

godotislate
he/him
commented

I think one of the protected methods should be removed from the original class.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work

Forgot to set to NW apparently.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Applied the suggestion, then followed up for some stray whitespace, then committed a couple of things to the wrong branch, but I think this is ready for review again.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed.

  • larowlan committed 81352a24 on 11.x 
    task: #3612987 Split up DependencyTest

By: catch
By: godotislate
(...

  • larowlan committed de512b74 on main 
    task: #3612987 Split up DependencyTest

By: catch
By: godotislate
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed de512b741b3 to main and 81352a2460b to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.