Problem/Motivation

This is usually the longest running kernel test, we can split it into two test classes with minimal work:

https://git.drupalcode.org/project/drupal/-/jobs/11065452

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3612409-nr-bot_aqtbd_l2.txt1.9 KBneeds-review-queue-bot

Issue fork drupal-3612409

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !16383

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3612409-nr-bot_aqtbd_l2.txt1.9 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

https://git.drupalcode.org/project/drupal/-/jobs/11078551 ComposerPatchesValidatorTest down to 87s although I think this was a fast test runner, since all the other package manager kernel tests were faster too (not by as much though).

28s for ComposerPatchesValidatorPreCreateTest down to 28s https://git.drupalcode.org/project/drupal/-/jobs/11078552

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Fine with me!

  • godotislate committed 5d6ea1e2 on 11.x 
    task: #3612409 Split ComposerPatchesValidatorTest in two

By: catch
(...

  • godotislate committed 6addfd55 on main 
    task: #3612409 Split ComposerPatchesValidatorTest in two

By: catch
godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 6addfd5 to main and 5d6ea1e to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.