Problem/Motivation

In order to ping a maintainer on GitLab, one needs the maintainer's GitLab username. We can look up their d.o username in MAINTAINERS.txt, but that is not always the same.

Proposed resolution

Add the GitLab username to MAINTAINERS.txt for each maintainer, even when it is the same as the d.o username.

Remaining tasks

User interface changes

None

Introduced terminology

None

API changes

None

Data model changes

None

Release notes snippet

N/A

CommentFileSizeAuthor
#17 3607216-nr-bot_d13rqwi8.txt91 bytesneeds-review-queue-bot
#5 3607216-nr-bot_ldhpv780.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3607216

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benjifisher created an issue. See original summary.

benjifisher opened merge request !16178

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Assigned: benjifisher » Unassigned
Status: Active » Needs review

I added all the GitLab user names.

I added the following explanation near the top of the file:

Each maintainer is listed with two user names: one for drupal.org in 'single
quotes' and one for git.drupalcode.org (GitLab) starting with @.

For example, my entry looks like this:

- Benji Fisher 'benjifisher' @benjifisher https://www.drupal.org/u/benjifisher

I am happy to modify the format and/or the explanation if anyone has a suggestion.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

The failing test looks like #3600807: [random test failure] Nightwatch command drupalInstallModule.js.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3607216-nr-bot_ldhpv780.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Needs work » Needs review

The conflict is from #3594199: Remove the Telephone module, easily resolved.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

To test this I got a list of all the unique entries in the maintainers file with grep "' @" core/MAINTAINERS.txt | sort -t: -u -k1,1. I loaded up the GitLab profiles of every maintainer in the list. They all loaded correctly, so there are no misspellings.

For those users whose GitLab and Drupal.org usernames are the same I took no further action, assuming that their D.o username was correct and needed no validation.

For those users with a difference in username I clicked the contact link in their GitLab profile which leads to their D.o user profile. I verified that the D.o name and usernames match what's listed in the maintainers file. There was 100% agreement between the profiles and what is listed in the maintainers file.

So I couldn't find any discrepancies. I think these changes are good to go.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Reviewed & tested by the community » Needs work

@dcam:

Thanks for the detailed review. My process was MAINTAINERS.txt -> d.o profile -> GitLab profile. Then I copied the username to the file. It is good to confirm by testing the other way around.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Needs work » Reviewed & tested by the community

Oops.

dww’s picture

dww
we/he/they
commented

My concern is that if we encourage @dww as my GitLab username, we do not want those in commit messages, since when core is cloned to GitHub (not lab) entirely other people get pinged.

This whole thing is a mess. I kind of hate that we’re allowed to define separate usernames on d.o and GitLab. Lots of things would be easier if we didn’t have that choice, and all accounts were forced to have the same name in both worlds.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

@dww:

I agree it would be simpler if the d.o and GitLab usernames were the same, but I do not see how this issue affects that.

My concern is that if we encourage @dww as my GitLab username, ...

That is your GitLab username. You and I do not contribute to the confusion. I am afraid I misunderstand your point.

dww’s picture

dww
we/he/they
commented

dww is my GL username. @dww is special syntax to mention me. Putting @dww in a comment on a GL issue or MR sends me a notification. Making this easier seems to be the intention of this issue. Okay. But, putting @dww in a commit message sends a notification to some other person on GitHub. That’s the problem we discovered when trying to figure out the right format for the “bylines” at the end of our default commit messages. We agreed no @ and to use d.o usernames, not GL ones.

https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintaine...

So my concern is that training people to think @dww is my GL username will lead to more people getting commit messages wrong.

We could use some other syntax in MAINTAINERS.txt to distinguish the two. Eg:

- Derek Wright ‘dww’ (dww)

Or whatever else. Just not @.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Needs review

Don’t want to block progress, but let’s get this out of the RTBC queue until we clarify the approach.

Thanks,
-Derek

dww’s picture

dww
we/he/they
commented

Ps definitely not the fault of this issue, but I’ll note for posterity it is confusing that commit messages being pushed to GitLab want to neither use GL functionality like @ mentions, nor even GL names. 🙃 That’s weird. 😂 But it’s the “best” we can do given all the circumstances. 😅

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

@dww:

Thanks for clarifying. The use case I have in mind is when I do want to ping someone on GitLab, but of course whatever I put into the file is apt to be (mis)used for other purposes.

Here is an updated version of what I wrote in Comment #3:

I added the following explanation near the top of the file:

Each maintainer is listed with two user names: one for drupal.org in 'single
quotes' and one for git.drupalcode.org (GitLab) in parentheses.

For example, my entry looks like this:

- Benji Fisher 'benjifisher' (benjifisher) https://www.drupal.org/u/benjifisher
dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

Perfect, thanks! That solves my concern. Back to RTBC.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3607216-nr-bot_d13rqwi8.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Needs work » Reviewed & tested by the community

I merged with the current main branch and resolved a simple modify/delete conflict from #3586221: Remove the Stable 9 theme. Back to RTBC.