Problem/Motivation

Follow-up from #3486503: Add a file parsing cache collector to replace some uses of FileCache. We should be able to use YamlCacheCollectorDiscovery.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3593485-nr-bot_u4osu8no.txt1.53 KBneeds-review-queue-bot
#6 3593485-nr-bot__wxjopdk.txt91 bytesneeds-review-queue-bot
#4 Screenshot from 2026-06-08 07-44-21.png437.03 KBcatch
#4 Screenshot from 2026-06-08 07-44-15.png410.33 KBcatch

Issue fork drupal-3593485

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !15977

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs work

This is green except performance tests. Want to actually do before/after profiling first before updating those.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new Screenshot from 2026-06-08 07-44-15.png410.33 KB
new Screenshot from 2026-06-08 07-44-21.png437.03 KB

Attaching before/after xhprof screenshots.

Looks like we save about 14ms in YAML parsing, and then 2ms is spent getting the new cache items from the persistent cache, so a net saving of 12ms (approximately).

But also shows that the total possible savings from YAML parsing (on admin/config/performance with Umami) is about 90ms, it'll be more on bigger sites with more modules. We won't be able to convert .info.yml or .services.yml but most other things should be fine.

We also have another 110ms from AttributeclassDiscovery which can get the same treatment.

So I think when both attribute and YAML discovery are converted, we'd be looking at about 200ms improvement on Umami cold cache web requests (minus whatever we can't save due to info/services parsing) (compared to an APCu cache miss) and more on larger sites.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3593485-nr-bot__wxjopdk.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Rebased.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3593485-nr-bot_u4osu8no.txt1.53 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review