Problem/Motivation

When looking at depreactaion messages for rector/update bot i saw the following:

  @trigger_error(__FUNCTION__ . 'is deprecated in drupal:11.4.0 and is removed from drupal:12.0.0. Use \Drupal\ckeditor5\Hook\Ckeditor5Hooks::updateCkeditor5HtmlFilter() instead. See https://www.drupal.org/node/3566774', E_USER_DEPRECATED);

That is actually missing a space which makes the message a bit weird. There are 3 places where this is the case right now. This MR fixes that.

Since this is not released yet, we could fix this quickly. Setting major since its time sensitive.

Steps to reproduce

na

Proposed resolution

Add a space

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3591520-nr-bot_30qm93ht.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3591520

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bbrala created an issue. See original summary.

bbrala’s picture

bbrala
Location Netherlands
commented
Title: Deprecation message in ckeditor is missing a space » Multiple 11.4.x deprecation messages missing a space

bbrala opened merge request !15838

bbrala’s picture

bbrala
Location Netherlands
commented
Version: main » 11.x-dev
Issue summary: View changes

bbrala opened merge request !15839

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

FWIW we can fix deprecation messages like this even after release - for example I'm pretty sure the links have been wrong before and we only noticed post-release.

nicxvan’s picture

nicxvan commented
Status: Active » Reviewed & tested by the community

I don't have access to the 11.x failures but I expect they are random.

Both branches look good!

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3591520-nr-bot_30qm93ht.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs work » Needs review

Hmm, if that is the case there is way more. A quick search for __FUNCTION__ . ' is deprecated shows quite a few hits. Do we include those here?

Some are 11.4, but also quite a few 11.3

quietone’s picture

quietone commented
Component: ckeditor5.module » other
Status: Needs review » Needs work

Oh rats. Yea, we really should fix them all to conform to policy. I found 8 more on 11.x and 3 on main. Since this can be fixed via the command line, let's do that.

I'll add to my list to check the current RTBC issues for this particular error.

Changing the component to other since this now affects more than one system.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs work » Needs review