Problem/Motivation

This is to execute part of #3159848: [Policy] Merge the minimal and standard install profiles into a starting point recipe.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

The standard install profile and recipe does not include default content types anymore.

CommentFileSizeAuthor
#9 3587118-nr-bot_6wx82znm.txt91 bytesneeds-review-queue-bot
#7 3587118-nr-bot_p52xr5tt.txt91 bytesneeds-review-queue-bot
#5 3587118-nr-bot_ovfh5vry.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3587118

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gábor hojtsy created an issue. See original summary.

gábor hojtsy opened merge request !15580

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review

I think I resolved all the issues other than this one remaining one which raises a few questions :) This is I believe due to how the recipe installation now installs modules which create some config on the fly while the standard profile is not doing that so the resulting config is different between the two installation methods. Not sure how to resolve this, so help is appreciated :) 

   Standard Recipe (Drupal\FunctionalTests\Core\Recipe\StandardRecipe)
     ✘ Standard
       ┐
       ├ Failed asserting that two arrays are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊  Array &0 [
       ┊      'create' => Array &1 [
       ┊ -········0·=>·'core.entity_view_mode.node.search_result',
       ┊ -········1·=>·'core.entity_view_mode.node.search_index',
       ┊ +········0·=>·'comment.settings',
       ┊ +········1·=>·'comment.type.comment',
       ┊ +········2·=>·'core.entity_view_mode.comment.full',
       ┊ +········3·=>·'image.style.wide',
       ┊ +········4·=>·'core.entity_view_mode.node.teaser',
       ┊ +········5·=>·'core.entity_view_mode.node.search_result',
       ┊ +········6·=>·'core.entity_view_mode.node.search_index',
       ┊ +········7·=>·'core.entity_view_mode.node.rss',
       ┊ +········8·=>·'core.entity_view_mode.node.full',
       ┊ +········9·=>·'system.action.comment_delete_action',
       ┊ +········10·=>·'system.action.comment_publish_action',
       ┊ +········11·=>·'system.action.comment_save_action',
       ┊ +········12·=>·'system.action.comment_unpublish_action',
       ┊ +········13·=>·'system.action.node_delete_action',
       ┊ +········14·=>·'system.action.node_make_sticky_action',
       ┊ +········15·=>·'system.action.node_make_unsticky_action',
       ┊ +········16·=>·'system.action.node_promote_action',
       ┊ +········17·=>·'system.action.node_publish_action',
       ┊ +········18·=>·'system.action.node_save_action',
       ┊ +········19·=>·'system.action.node_unpromote_action',
       ┊ +········20·=>·'system.action.node_unpublish_action',
       ┊ +········21·=>·'system.action.taxonomy_term_unpublish_action',
       ┊ +········22·=>·'system.action.taxonomy_term_publish_action',
       ┊ +········23·=>·'core.entity_view_mode.taxonomy_term.full',
       ┊ +········24·=>·'taxonomy.settings',
       ┊ +········25·=>·'taxonomy.vocabulary.tags',
       ┊ +········26·=>·'field.storage.comment.comment_body',
       ┊ +········27·=>·'field.field.comment.comment.comment_body',
       ┊ +········28·=>·'core.entity_view_display.comment.comment.default',
       ┊ +········29·=>·'core.entity_form_display.comment.comment.default',
       ┊ +········30·=>·'views.view.comment',
       ┊ +········31·=>·'views.view.comments_recent',
       ┊ +········32·=>·'views.view.taxonomy_term',
       ┊      ],
       ┊      'update' => Array &2 [
       ┊          0 => 'core.extension',
       ┊ +········1·=>·'user.role.anonymous',
       ┊ +········2·=>·'user.role.authenticated',
       ┊ +········3·=>·'user.role.content_editor',
       ┊ +········4·=>·'views.view.archive',
       ┊ +········5·=>·'views.view.frontpage',
       ┊      ],
       ┊      'delete' => Array &3 [],
       ┊      'rename' => Array &4 [],
       ┊  ]
       │
       │ /builds/core/tests/Drupal/FunctionalTests/Core/Recipe/StandardRecipeTest.php:138
       ┴
smustgrave’s picture

smustgrave commented

Should the default content be moved to it's own recipe? Would that solve the issue or am I completely wrong?

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3587118-nr-bot_ovfh5vry.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3587118-nr-bot_p52xr5tt.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Everything looks good to me!

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3587118-nr-bot_6wx82znm.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.