Problem/Motivation

Follow up from #3311365-92: Use PHP attributes for route discovery per @catch:

Whether or not we add file cache support should probably depend on whether the controller classes get loaded for other reasons, and if we think it's possible to remove that too - if we do then it might be worth doing. Although there's also the issue that most router rebuilds happen on the cli, it's directly rebuilt when you call drush cr (as opposed to most other caches which get built on the next request that needs them). Which goes back to #3486503: Add a persistent cache for file-based discovery based on FileCache. All reasons not to do it here but worth a follow-up definitely.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Comments

godotislate created an issue. See original summary.

catch’s picture

godotislate’s picture

This is probably blocked on #3486503: Add a persistent cache for file-based discovery based on FileCache. I think there was also a comment/discussion that assessing whether the file cache is needed should wait until after we've done the conversion of core routes to attributes in #3584794: Convert core routes to PHP attributes and done performance tests.

godotislate’s picture

Title: Look into adding a file cache for route discovery » [PP-2] Look into adding a file cache for route discovery
Related issues: +#3584794: Convert core routes to PHP attributes