Problem/Motivation
In TimestampFormatter
$form['time_diff']['description'] = [
'#type' => 'item',
];
item is '#input' => TRUE so this gets into config (opsie).
Steps to reproduce
Proposed resolution
Just add description to schema. Is it a good way to do it? Nope. It's not. But what else can be done? Much like the block issue, removing description from Views and such is too hard. And I do not see a submit method for FormatterInterface::settingsForm so it can't be removed even from the values array easily.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | drupal-core-time_diff-missing-schema-3574942-2.patch | 529 bytes | yce |
Issue fork drupal-3574942
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
yce commentedAdding the description field's schema to `core.entity.schema.yml` seems to solve the validation issue.
Comment #4
ishani patel commentedI've raised a PR for the time diff description.
Kindly check and review it.
Thank you!
Comment #6
ishani patel commentedComment #7
idebr commentedThis issue was reported earlier in #3400522: time_diff 'description' field not propagated to existing core views, view tests or core schema after being added to TimestampFormatter. I'll close this issue as a duplicate, so we can focus our efforts in the related issue.