Problem/Motivation

wrapSchemaException() can be called from onEntityTypeCreate(), in which case this is not correct:

> $message = 'Exception thrown while performing a schema update.';

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3573790

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

ishani patel made their first commit to this issue’s fork.

ishani patel opened merge request !15395

joachim’s picture

joachim commented

I'm not sure what the best fix is here.

I would be inclined to say we need better granularity for handling the exceptions, but I don't fully understand what the wrapSchemaException is doing.

joachim’s picture

joachim commented
Status: Active » Needs work

Ok, having read the code, I'd say to add an entire $message parameter to wrapSchemaException().

Though in the other place where this is done (the renderer), I do find it confusing to have an error message as a parameter when there isn't necessarily an error.