Problem/Motivation
The Views setting option for the "Any" value appears to have no effect on the output except for the top row in the grouped exposed filters configuration form.

I also don't find any use in the code of that configuration (old_any) except:
- On the Views settings form (
/admin/structure/views/settings)
- On the grouped exposed filters configuration form.
- In YAML configuration files.
Here are screenshots of the grouped filters configuration form and the preview of the exposed form, showing where the setting does and doesn't have an effect.


Steps to reproduce
Proposed resolution
If my understanding of the setting and its lack of effect is correct, remove it.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Comments
Comment #2
kentr commentedMaybe it's really a bug, since the setting doesn't do what it sounds like it's meant to.
Comment #3
chaitanyadessai commentedPlease review patch.
Comment #4
jesus_md commentedTested the patch in #3 and the code checks out. I agree with the analysis in the summary: nothing else reads
ui.exposed_filter_any_label, and the exposed form always renders- Any -because it's hardcoded in the filter handlers. So the setting only ever changed the top row of the grouped filters table in the admin UI.Before the patch the setting was stored as
old_any, the select showed on/admin/structure/views/settings, and the grouped table for the content view's "Published status" filter showed<Any>. After applying it and runningdrush updb, the post-update removed the key, the select is gone, the settings form still saves without errors, and the grouped table shows- Any -. The new update test,SettingsTestandExposedFormUITestpass, and phpcs is clean.Setting to Needs work for a few non-code things:
main, with one hunk offset by 71 lines.<Any>to- Any -, which now matches what visitors see.#[IgnoreDeprecations]on the new update test doesn't look necessary.Tested on:
Comment #5
jesus_md commentedComment #6
kentr commentedComment #8
chaitanyadessai commentedMR raised please review.
Comment #9
amitgoyal commentedAdded a change record for the removed views.settings:ui.exposed_filter_any_label config key: https://www.drupal.org/node/3626113
Reviewed MR !17254:
- Pipeline is green (only allow_failure PHP 8.6-ubuntu next-major jobs failed, unrelated to this change)
- No open review threads
- PHPCS clean on all changed files
- ViewsRemoveExposedFilterAnyLabelUpdateTest, SettingsTest, and ExposedFormUITest all pass locally
- Verified locally: the "Any" select is gone from /admin/structure/views/settings, and the grouped exposed filters table now shows the "- Any -" label instead of the old bracketed label
Moving to RTBC.