When a page or article is created, an "Add new comment" link is displayed. Following this through and adding a comment all works fine, but the "Add new comment" link never returns i.e. you can only reply to the existing comment.

Steps to reproduce:

  1. Create a new page (or article), fill it in and save it.
  2. Click on "Add new comment", fill it in, preview and save it
  3. No "Add new comment" link is displayed.

Comments

dawehner’s picture

this is a very strange issue

i have written this into nodetpl

    <?php if ($links): ?>
      <div class="links"><?php 
      drupal_set_message($links);
      print $links; ?></div>
    <?php endif; ?>

And "add new comment" is displayed in messages but it is not printed on the page, what a issue

dawehner’s picture

Status: Active » Needs review
StatusFileSize
new1.02 KB

this is css issue,
because the html is generated

but the margin in #comments {style.css?F (Linie 707) of garland hides the link

this patch fixes the issue, but i don't know wether this has issues on other stuff (css i not my world)

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

Status: Needs work » Needs review

That fail can't be valid.

dawehner’s picture

heheh thats true,

perhaps the " " was removed in node.tpl.php?

Status: Needs review » Needs work

The last submitted patch failed testing.

dawehner’s picture

Status: Needs work » Needs review
cburschka’s picture

Status: Needs review » Needs work

Testbot is right. Patch erroneously includes a whitespace fix to node.tpl.php that has been committed by now (I get asked if I want to reverse the patch).

That should never have been in here in the first place, as the patch isn't concerned with node.tpl.php at all. It's best to avoid this by cleaning your local CVS copy out regularly, or diffing only the file you want to submit a change for. :)

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new852 bytes

mh strange i do cvs update -C quite often

here is a rerole

xmacinfo’s picture

Which patch is better?

You patch or this patch: #438224: "Post comments without approval" permission name is completely misleading --> at #4. ;-)

cburschka’s picture

margin: 0 -25px 0;

Are the top and bottom margins something other than 0 by default, so that they need to be overridden?

If they are not, then I would suggest using "margin-right: -25px" which is easier to read.

netsensei’s picture

Hehe, there you touched the sensitive 'px vs em' topic. :-)

I respected the em unit in my patch to make sure the relative spacing above and below would be respected over different resolutions, font sizes, etc. I wouldn't change this to px.

jpoesen’s picture

Status: Needs review » Closed (duplicate)
silverwing’s picture

Issue tags: -comments

Closing comments (spam)