Problem/Motivation

forms for user interface translation (/admin/config/regional/translate) are reloading the page after each submit, we can do better

Steps to reproduce

Proposed resolution

htmx-ify the forms
sort of combine the following issues: #3522597: Return only main content for selected htmx requests and #3535173: Support dynamic forms using HTMX

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3538544-nr-bot_d59tk84z.txt4.28 KBneeds-review-queue-bot

Issue fork drupal-3538544

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nod_ created an issue. See original summary.

nod_ opened merge request !12861

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
commented

Bunch of updates, implements the _wrapper_format=drupal_htmx to reduce the size and contents of the ajax requests

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3538544-nr-bot_d59tk84z.txt4.28 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Title: Ajaxify the user interface translation forms » [PP-1] Ajaxify the user interface translation forms
Issue summary: View changes
Status: Needs work » Postponed
Related issues: +#3522597: Return only main content for selected htmx requests
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Related issues: +#3535173: Support dynamic forms using HTMX
nod_’s picture

nod_
Primary language French
Location Lille
commented
Title: [PP-1] Ajaxify the user interface translation forms » Ajaxify the user interface translation forms
Status: Postponed » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
commented
Title: Ajaxify the user interface translation forms » [PP-1] Ajaxify the user interface translation forms
Status: Needs review » Postponed
Related issues: +#3546105: Automatically manage _wrapper_format for HTMX requests and clean up ajax_page_state in urls

Because of how these forms work we need #3546105: Automatically manage _wrapper_format for HTMX requests and clean up ajax_page_state in urls before

nod_’s picture

nod_
Primary language French
Location Lille
commented
Title: [PP-1] Ajaxify the user interface translation forms » Ajaxify the user interface translation forms
Status: Postponed » Needs work

We should be able to deal with it here, need to try a few things where we might have to refactor the backend a bit

nod_’s picture

nod_
Primary language French
Location Lille
commented

Got it sort of working but there are problems:

  1. Pager links are very broken, they get all the form stuff added to the query string and since we exclude the libraries trying to navigate to them is just not working.
  2. The session values never gets updated so default filtering stays at what it was. When the page is refreshed we don't get the last filtered thing.
nod_’s picture

nod_
Primary language French
Location Lille
commented

got the pagination working but it's not limited to this form, I don't know what else it might break

joaopauloc.dev made their first commit to this issue’s fork.

joaopauloc.dev’s picture

joaopauloc.dev commented

After talking to @nod_ in the slack, he mentioned about the new boost htmx feature that he worked in this issue. Since his approach is much better than the previous htmx flag variable. I'm bringing the changes related with the pager and htmx class to make it possible to use the boost approach in this issue.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.