Griffyn Heels wrote to ask if I still wanted to be a core topic maintainer, and to file an issue if not.
Please remove me from MAINTAINERS.txt
| Comment | File | Size | Author |
|---|
Issue fork drupal-3537409
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
andrewmacpherson commentedComment #4
andrewmacpherson commentedI have no idea what went wrong in creating that merge request. I tried doing it quickly with editing the MAINTAINERS.txt.
Comment #5
andrewmacpherson commentedRight. It's the one called: 3537409-remove-accessibility-topic-maintainer-andrewmacpherson
Comment #7
andrewmacpherson commentedStrewth. It's gone wrong agin.
It all looked fine, until I pressed the GitLab button to create the merge request. Now it's picking up changes for a different issue. I didn't edit any of those files.
Comment #8
andrewmacpherson commentedI think these misadventures are because I'm tried to fork from the 11.2.x branch, but the GitLab was picking 11.x to create the merge requests. (Maybe? The "commits ahead/behind" message gave me that clue, and
git log 11.x..11.2.x --oneline | wctallies with it.)Sod this for a box of frogs. Just do it the old fashioned way wi' a patch file.
Comment #11
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #12
andrewmacpherson commentedThe bot is bothered by the merge requests, not the patch in #8
Comment #15
quietone commentedComment #16
quietone commentedComment #19
nicxvan commentedThank you for helping out with one of my first core issues! https://www.drupal.org/project/drupal/issues/3333401
I took care of the mr for you, I think you were right it was because the branch was 11.2, it needed to be 11.x
Comment #20
andrewmacpherson commentedThanks nicxvan, that'll do nicely. I was used to filing against a major.minor branch in the past; I gather it's just against the current major version now.
Comment #21
andrewmacpherson commentedRe. #19: Ah yes, the skipped heading levels for the pager. I remember the issue very well. Thanks for seeing it through; the heading level option is a rather good outcome.
Comment #22
benjifisherThank you for all the work you have done for Drupal over the years! Drupal has gained a lot from your expertise. Personally, I picked up a few pointers about accessibility (a11y) but I am certainly not an expert.
Comment #27
xjm@andrewmacpherson, thank you so much for all your dedicated work on core's accessibility! You made a huge difference for core in helping us to think critically about accessibility for so many major core features. I still think of your input whenever I remind myself or others that we need to put accessibility first.
Also, thank you for teaching me a marvelous new cuss:
Committed to 11.x, 11.2.x, 10.6.x, and 10.5.x. I will also update the core node, the Google group, and the maintainer channel since this was @andrewmacpherson's single maintainer role.
Comment #28
xjm