Griffyn Heels wrote to ask if I still wanted to be a core topic maintainer, and to file an issue if not.

Please remove me from MAINTAINERS.txt

Issue fork drupal-3537409

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

andrewmacpherson created an issue. See original summary.

andrewmacpherson’s picture

Title: Remove accessibility maintainer - andrewmacpherson » Remove accessibility topic maintainer - andrewmacpherson
Issue summary: View changes

andrewmacpherson’s picture

I have no idea what went wrong in creating that merge request. I tried doing it quickly with editing the MAINTAINERS.txt.

andrewmacpherson’s picture

Right. It's the one called: 3537409-remove-accessibility-topic-maintainer-andrewmacpherson

andrewmacpherson’s picture

Strewth. It's gone wrong agin.

It all looked fine, until I pressed the GitLab button to create the merge request. Now it's picking up changes for a different issue. I didn't edit any of those files.

andrewmacpherson’s picture

Status: Active » Needs review
StatusFileSize
new523 bytes

I think these misadventures are because I'm tried to fork from the 11.2.x branch, but the GitLab was picking 11.x to create the merge requests. (Maybe? The "commits ahead/behind" message gave me that clue, and git log 11.x..11.2.x --oneline | wc tallies with it.)

Sod this for a box of frogs. Just do it the old fashioned way wi' a patch file.

andrewmacpherson changed the visibility of the branch 3537409-remove-accessibility-topic-maintainer-andrewmacpherson to hidden.

andrewmacpherson changed the visibility of the branch 3537409-remove-accessibility-maintainer to hidden.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

andrewmacpherson’s picture

Status: Needs work » Needs review

The bot is bothered by the merge requests, not the patch in #8

quietone’s picture

Version: 11.2.x-dev » 11.x-dev
quietone’s picture

Issue tags: +Project governance

nicxvan made their first commit to this issue’s fork.

nicxvan’s picture

Thank you for helping out with one of my first core issues! https://www.drupal.org/project/drupal/issues/3333401

I took care of the mr for you, I think you were right it was because the branch was 11.2, it needed to be 11.x

andrewmacpherson’s picture

Status: Needs review » Reviewed & tested by the community

Thanks nicxvan, that'll do nicely. I was used to filing against a major.minor branch in the past; I gather it's just against the current major version now.

andrewmacpherson’s picture

Re. #19: Ah yes, the skipped heading levels for the pager. I remember the issue very well. Thanks for seeing it through; the heading level option is a rather good outcome.

benjifisher’s picture

Thank you for all the work you have done for Drupal over the years! Drupal has gained a lot from your expertise. Personally, I picked up a few pointers about accessibility (a11y) but I am certainly not an expert.

  • xjm committed 6e312d07 on 11.x
    Issue #3537409 by andrewmacpherson, nicxvan: Remove accessibility topic...

  • xjm committed 981fa767 on 11.2.x
    Issue #3537409 by andrewmacpherson, nicxvan: Remove accessibility topic...

  • xjm committed 13b58e71 on 10.6.x
    Issue #3537409 by andrewmacpherson, nicxvan: Remove accessibility topic...

  • xjm committed b251428d on 10.5.x
    Issue #3537409 by andrewmacpherson, nicxvan: Remove accessibility topic...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

@andrewmacpherson, thank you so much for all your dedicated work on core's accessibility! You made a huge difference for core in helping us to think critically about accessibility for so many major core features. I still think of your input whenever I remind myself or others that we need to put accessibility first.

Also, thank you for teaching me a marvelous new cuss:

Sod this for a box of frogs

Committed to 11.x, 11.2.x, 10.6.x, and 10.5.x. I will also update the core node, the Google group, and the maintainer channel since this was @andrewmacpherson's single maintainer role.

xjm’s picture

Version: 11.x-dev » 10.5.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.