Problem/Motivation
Now also targeting the form from #3528251: Layout Builder "Discard changes" confirmation form is destructive and does not communicate consequences to the user.
This issue has been made to address the language in the "Discard changes" & "Revert to defaults" Layout Builder confirmation forms.
People with enough Layout Builder experience will understand what is means when you use these forms, but I don't think its clear for content editors.
Steps to reproduce
1. Use the "Discard changes" or "Reset to defaults" button in the Layout Builder interface.
2. See the text of the confirmation dialog.
3. Scratch your head in perplexity.
Proposed resolution
Update the title & message on these forms based on the outcomes from #22 https://www.drupal.org/project/drupal/issues/3528494#comment-16178607
Remaining tasks
Update the text in both forms
Merge
User interface changes
Text in the Revert layout & Reset to defaults confirmation form will change
Introduced terminology
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #28 | Screenshot from 2025-07-07 14-38-28.png | 31.41 KB | danielveza |
| #28 | Screenshot from 2025-07-07 14-38-13.png | 31.39 KB | danielveza |
| #20 | Screenshot from 2025-07-04 09-23-20.png | 58.25 KB | danielveza |
| #20 | Screenshot from 2025-07-04 09-20-16.png | 80.44 KB | danielveza |
| #20 | Screenshot from 2025-07-04 09-17-55.png | 42.51 KB | danielveza |
Issue fork drupal-3528494
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3528494-improve-clarity-of
changes, plain diff MR !12314
Comments
Comment #3
libbna commentedComment #5
libbna commentedI have replaced the revert confirmation text
Are you sure you want to revert this to defaults?withThis layout will be reverted to the default layout, any custom overrides will be lost. Are you sure you want to continue?. However, in my opinion, this message may be a bit too long. As noted in one of the comments on https://www.drupal.org/project/drupal/issues/3528251, and to maintain consistency, could we consider using the existing messageAny unsaved changes to the layout will be lost. This action cannot be undone.instead?Comment #6
libbna commentedComment #7
danielvezaIn the Revert form, this message wouldn't be accurate. Changes to the layout have already been saved.
Reverting to default is more destructive (but can be restored by reverting to a past revision) than discarding changes (Which is just clearing the tempstore), so I think a more verbose message makes sense here.
Comment #8
libbna commentedUnderstood, thanks @danielveza for the clarification. I'm unassigning myself for now—if any further changes are needed, I'm happy to jump back in.
Comment #9
smustgrave commentedSeems like a good simple update
Comment #10
mark_fullmerI'd offer some suggestions on the current proposed text, shown here:
1. I'm not sure that for most content editors, the technical term "custom overrides" will be clear. Most content editors think of the changes they are making to a Layout Builder page as "adding content" or "modifying content." On top of this, it really depends on how Layout Builder is being used on a given site. If a Layout Builder entity view display is configured to display a bunch of fields from the entity, then what the content editor does with Layout Builder is a "modification" to the layout, or perhaps even an "override." If, however, the Layout Builder entity view display is more of a blank slate to which content editors add inline blocks of content, then content editors aren't going to think of this as a "modification/override" but as content additions.
2. From a grammatical perspective, a comma shouldn't be used to separate two independent clauses.
Proposed revised language that tries to find the right balance between Drupal technical terminology and content editor comprehension:
Comment #11
danielveza+1 to the suggestion from @mark_fullmer.
Adding the novice tag since this should be a good first issue for an new contributor. If its not picked up by a novice or @libbna in a week or so I'll jump in and do it
Comment #12
libbna commentedI have updated the text as suggested by @mark_fullmer. Changing the status to needs review.
Comment #13
smustgrave commentedThanks for making that change. LGTM.
Comment #14
xjmThis is a great improvement! The operation is indeed pretty destructive.
One quibble, though: As written, "inline content" sounds worse than it is. That sounds like... all your content, rather than just potentially a whole bunch of content.
Do we not use the term "inline blocks" in the user interface?
Comment #15
xjmThe action to make them in the UI is "create content block" so let's use that language:
Edit: What does happen to those inline blocks when you perform this operation?
Comment #16
xjmAfter looking at #3528251: Layout Builder "Discard changes" confirmation form is destructive and does not communicate consequences to the user (which I missed at first), I think we need to discuss both in the same issue. This should be merged back there and then closed as a duplicate.
Comment #17
danielvezaI think the existing text for this particular form is pretty terrible , I'd recommend we merge this so it can at least be improved without being stalled on discussions about the particular language tweaks.
The points raised in #16 are 100% valid, but my 2c would be to improve this now. The discussions can and should still continue in the other issue, but I don't want the text for this one to stay in it's current state if the other issue takes awhile to get in.
Comment #18
xjmThanks @danielveza! I agree that this is a serious issue. In fact, I'm bumping this to major and changing it to bug. Retitling as such
Please keep in mind that regardless of what is committed when, both these improvements are string changes, and as such will only be committed to 11.x according to our allowed changes policy for frontend bug fixes. As such, the fixes will only be available in 11.3.0, which is released in December. I'm confident we can get both these issues fixed by then, whether we handle them together or separately!
As a release manager, I make recommendations about issue scoping so that we manage our changes in the best way we can.
In this case, these two usability problems are similar, and the users need to understand the two different operations. That's why I think we need to discuss them together, and have an usability review of our changes according to the core usability gate. I'm not tagging for usability review yet because we would need screenshots and such.
I'm also going to seek the input of our UX managers since what we do here is ultimately under their guidance. Thanks everyone!
Comment #20
danielvezaSimilar to #3528251: Layout Builder "Discard changes" confirmation form is destructive and does not communicate consequences to the user, while prepping screenshots for this I don't think the approach currently taken in the code is correct. I was thinking that the description of the text had been updated, but it's actually the title. Attaching some screenshots of the form before/after applying the current MR, and a screenshot of an example of how it could look with overriding ::getDescription as well.
Current form in 11.x:
After applying MR:
Screenshot from my local, moving some of the text into the description (The title question still feels too long here):
Comment #21
danielvezaI've attached screenshots of this and #3528251: Layout Builder "Discard changes" confirmation form is destructive and does not communicate consequences to the user with some suggestions of how it currently looks and how it should potentially look, so it can be reviewed by the UX team and a choice on the question & description can be made for both the question & the description of both issues.
Comment #22
benjifisherWe discussed this issue and #3528251: Layout Builder "Discard changes" confirmation form is destructive and does not communicate consequences to the user at #3532804: Drupal Usability Meeting 2025-07-04. That issue will have a link to a recording of the meeting. For the record, the attendees at today's usability meeting were @benjifisher, @rkoller, and @simohell.
We agree with Comment #16: this issue should be combined with #3528251. @danielveza, your own Comment #20 suggests that the current MR for this issue is not a good solution (and we agree). That seems at odds with your reasons in Comment #17 for not combining the issues.
We did a little testing, and we can confirm that inline blocks (Content blocks created in Layout Builder) are deleted from the database if you Discard changes. If you have inline blocks saved in a custom layout, and you Revert to defaults, then they are still in the database but you cannot use them nor even edit them. (The page at
/admin/content/blockis a View. By default, it filters on Reusable: True. It is easy to edit that view and expose that filter, and then you can list the inline blocks.)We did not settle on recommended text for these forms, but we can suggest some guidelines:
We also noticed a few problems that are not in the scope of this issue. The Umami demo profile does not display the confirmation form well. It would be nice to implement #1842036: [META] Convert all confirm forms to use modal dialog.
If you want more feedback from the usability team, a good way to reach out is in the #ux channel in Slack.
Comment #25
xjmThanks @danielveza and @benjifisher. Adding credits from the Usability meeting.
Comment #26
xjmComment #27
danielvezaUpdating the IS to clarfiy new scope for this issue
Comment #28
danielvezaTaken a stab at implemented the suggestions from #22. Both forms are now being updated. Changes pushed & tests are green. Adding some screenshots of the new text and how it looks on the form. As per the suggestion in #22, I've also included the label of the entity (where possible), falling back to a more generic message if no entity context is available (Like when editing a default layout).
Comment #29
xjmThe meanings of these two actions are much clearer with the updated form texts, thanks! Posted a couple small suggestions.
Comment #30
mark_fullmerI'll note that if the "Help" module is installed, the presumably helpful text "This layout builder tool allows you to configure the layout of the main content area. To manage other areas of the page, use the block administration page. Forms and links inside the content of the layout builder tool have been disabled." is embedded in this confirmation page, causing the important new text to be deemphasized:
This importance could be elevated by boldfacing the text, if desired. That being said, the language per the latest changes is accurate and grammatically correct, so I'm setting this to RTBC.
Comment #31
catchThis looks good. Committed/pushed to 11.x, thanks!