Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Dec 2008 at 23:46 UTC
Updated:
2 Jan 2014 at 23:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
moshe weitzman commentedComment #2
dries commentedI've committed this to CVS HEAD. Thanks Dmitri.
The patch failed to apply against DRUPAL-6 so I'm marking this 'fixed' for now. If this needs to be backported, feel free to re-open this issue.
Comment #3
ksenzeeThis isn't this patch's fault, but reading it I noticed that there's a mismatch here. If the path is now "admin/build/types", arg(1) returns "build", not "content". I'm not on my dev machine or I'd provide an actual patch -- sorry about that.
Comment #4
jhodgdonRE #3 - The arg() doc header has been changed again, due to more changes in core paths, and now says
When viewing a page at the path "admin/structure/types", for example, arg(0) returns "admin", arg(1) returns "content", and arg(2) returns "types".
http://api.drupal.org/api/function/arg/7
This does need to be fixed. Good project for a novice doc contributor.
Comment #5
jastraat commentedsorry - I didn't think this had been assigned and I was looking for a good practice issue.
Comment #6
jastraat commentedComment #7
jastraat commentedComment #8
jhodgdonjastraat: You cannot normally mark your own patch as "reviewed and tested by the community". You need to wait for someone else to review it.
I've just reviewed it. It's fine. :)
Comment #9
jhodgdonComment #10
jastraat commentedGenerally no - but it was a very, very tiny string change :)
Comment #11
dries commentedCommitted to CVS HEAD. Thanks.