Problem/Motivation

TestXSSTitleBlock is used for old XSS tests. It only achieves the desired goal by not making the admin_label a translatable markup, something that is not possible with Attribute tests as that has a type and must be a TranslatableMarkup object.

There are also some related leftover category tests that test for a string that doens't exist anymore in core.

Steps to reproduce

Proposed resolution

Changes the test to instead test with a user-provided label for a regular block and removes the category test coverage.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3509244

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Ready for review.

berdir opened merge request !11304

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good refactor without test loss

  • catch committed 15fa2d85 on 11.x 
    Issue #3509244 by berdir: Remove TestXSSTitleBlock, update block XSS...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !11304

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.