Support Testing View Protected Fields

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

Change should have test coverage.

Thanks for opening this issue, you've been on fire lately.

I was thinking, wouldn't this "just work" (tm) if you set field permissions? Although i'm a little weary if this is possible to allow post/path but then not view. But this might just work because of entity api.

function YOUR_MODULE_NAME_entity_field_access($operation, FieldDefinitionInterface $field_definition, AccountInterface $account, FieldItemListInterface $items = NULL) {
  $result = AccessResult::neutral();
  if ($field_definition->getName() == 'field_we_care_about') {
    if ($operation == 'edit' && !in_array('administrator', $account->getRoles())) {
      $result = AccessResult::forbidden();
    }
  }
  return $result->addCacheContexts(['user.roles:administrator']);
}

Would see if there is an existing test in jsonapi that can be expanded or would have to write a brand new one.

I don't see anything that calls that variable to testing.

Before moving to review please check that the pipeline is passes the code standard checks.
If a test fails that's fine just shows the fix needs to be tweaked usually
When adding test coverage, if the pipeline could run, there's a test-only feature that checks if the test covers the change.

Thanks for working on it.

So the summary and or title don’t really make sense. The summary seems like it wants to add a new feature but I just see changes to test files. Yes feature requests need test coverage but also needs the new feature added to the MR so we can see that the tests pass.

Yeah, i dont think you need test coverage there, you do need to address the other small nits though. Although the out of scope space for TRUE i'd say is ok.

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.