Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Nov 2024 at 22:32 UTC
Updated:
2 Jan 2025 at 01:44 UTC
Jump to comment: Most recent
Comments
Comment #4
quietone commented@ankitv18, this issue is tagged as a Novice, and is best to leave such issues for a first time contributor. Unless, of course, the issue has become stale.
Comment #5
ankitv18 commentedI saw no one has touched this issue since past two days that's why raised the MR.
Anyways I'll keep this issue in Active state for new members.
Comment #6
dww2 days during a holiday week isn't much time to give new contributors a chance to find and work on it. This is not a release-blocking, urgent task, so there's no need to rush. 😅
That said, since the work is already done, and there's a reviewable MR, leaving the status 'Active' does nothing to help new users, and might potentially lead to confusion.
Comment #7
dwwLooks like random fails in the pipeline. I just retried the jobs. Let's see if the bot is happy with the re-runs (should be).
Comment #8
dwwBot is happy. MR is simple and does the trivial change requested by the clear issue summary.
I tried some manual local testing to make sure the sniff does what we want. I made the following change:
Then I did this:
Without this MR change applied, phpcs passed. Once I added the MR diff, I got:
Then I tried phpcbf to make sure that worked, too:
So all is working as expected, and enforcing the standard we adopted.
Nothing else to do here. RTBC.
Thanks,
-Derek
Comment #9
ankitv18 commentedTotally make sense ~~ I'll keep that in my mind :D
And thanks for the quick review & moving into RTBC.
Comment #11
larowlanCommitted to 11.x - thanks!