Problem/Motivation

Method getMockForAbstractClass() of class PHPUnit\Framework\TestCase is deprecated in PHPUnit 10.

Some uses were removed as part of #3217904: [meta] Support PHPUnit 10 in Drupal 11, but there's a relevant number of places where this is still used.

Proposed resolution

replace in class ContentEntityBaseUnitTest

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3489380

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !10305

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Reviewed the change and don't believe any coverage has been lost and inline with other changes like this.

LGTM

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

I think there should be return types on the new methods in the stub file.

anish.ir made their first commit to this issue’s fork.

anish.ir’s picture

anish.ir commented
Status: Needs work » Needs review

Hey,

I have added the return types to the stub file as suggested.
Please review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Return types appear to have been added.

larowlan closed merge request !10305

  • larowlan committed e61d212f on 11.x 
    Issue #3489380 by mondrake, anish.ir, quietone: Method...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed to 11.x - thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.