Problem/Motivation

Steps to reproduce

Proposed resolution

Add ignore for the following and reformat the cspell ignore lines.

  1. drupalelementstyle
  2. drupalelementstylecommand
  3. drupalelementstyleediting
  4. drupalelementstyleui
  5. drupalhtmlbuilder
  6. drupalmediaediting
  7. drupalmediatoolbar
  8. imagetextalternative
  9. interactable
  10. mediaimagetextalternative
  11. mediaimagetextalternativeediting
  12. mediaimagetextalternativeui
  13. xmlhttprequest

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3483908

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

quietone’s picture

Status: Active » Needs review
smustgrave’s picture

Question, I feel ckeditor has a number of words that appear here. Should we add to drupal dictionary or maybe consider a ckeditor dictionary?

quietone’s picture

It is done this way to following existing practice. The use of 'cspell:ignore' for these ckeditor5 only words began when ckeditor5 was added to core in 2022. I wasn't involved in that so the people on the issue made the decision to add ignore lines in individual files. And this does following existing practice of ignoring topic specific words by file.

An advantage of doing it this was is that it restricts these misspellings to where they are actually used. That can be helpful fs the word is one that could also be used incorrectly elsewhere in core. One such example is 'colour', which is in the dictionary. With it in the dictionary and not the individual file where it is use the word could be introduced elsewhere in core. That can be avoided by having the words ignored where they are used. On the other hand that can be a problem if an ignored line is added to the dictionary but it is not removed from an individual file. But for that case, I have written a script to find those, but that issue is stalled.

Adding another dictionary would create more work for little gain. It would require news script for creation and then extra work to make sure everything stays in sync. Plus, if we make one for a module or a subsystem, it opens the door for making more dictionaries.

Hope that helps.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Just thought I'd throw it out there. Rest seems fine.

quietone’s picture

Rebase with no conflicts

Anonymous’s picture

akulsaxena made their first commit to this issue’s fork.

Anonymous’s picture

Rebased

  • larowlan committed 18753d34 on 11.x
    Issue #3483908 by quietone: Fix spelling for ckeditor related words
    
larowlan’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 11.x - thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.