Problem/Motivation
Steps to reproduce
Proposed resolution
Use a script to make the changes
Exclude changing the URL in migration tests fixtures. These are core/modules/migrate_drupal/tests/fixtures/drupal6.php and core/modules/migrate_drupal/tests/fixtures/drupal7.php.
Remaining tasks
#3562778: Replace http://example.com with https://example.com in update test fixtures
Completed
#3508843: Replace http://example.com with https://example.com in core/lib
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3462866
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
quietone commentedComment #3
koustav_mondal commentedWorking on it.
Comment #5
koustav_mondal commentedReplaced http://example.com. Please have a look.
Comment #6
smustgrave commentedAppears to have pipeline issues
Also
don't think this was taken into account
Also don't think we should change anything in the vendor directory.
Comment #7
smustgrave commentedComment #8
quietone commented@koustav_mondal, Welcome to Drupal! Thanks for working on this issue.
When working on an issue like this it helps to share how you found the instances to fix. For example. did you use grep, the search function of an IDE, or write your own script? If you used a script, it should be uploaded.
We also need to make sure that these changes are not changing tests where the use if 'http' is correct. With the large number of changes here that will be difficult. I think this needs to be split into separate issues, not sure how many.
A start is to make a separate issue for the non-test changes in core/lib/Drupal. I think we need to make sure that production code is not changed.
@koustav_mondal, do you wish to make the separate issue and move those changes?
Comment #9
koustav_mondal commented@quietone I didn't write any script, used the search function of an IDE. Do I revert back the changes in test? Or you can create an issue for not non-test changes.
Comment #10
quietone commented@koustav_mondal, I think for now this needs to focus on splitting this issue into several smaller more manageable issues. To start can you move the changes in 'core/lib' to #3508843: Replace http://example.com with https://example.com in core/lib. It is not the most exciting work but it does happen that we need to split an issue into smaller, more manageable pieces.
Given that this is changing nearly 200 files, it will likely need to be split further. I can check in on this in a few days.
Comment #11
koustav_mondal commentedThank you @quietone, I'll move the changes in the new issue.
Comment #12
mradcliffeI am removing the Novice tag from this issue because I think it is not as clear how to split the based on the various meta issues.
I’m using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is...
Comment #13
quietone commented@mradcliffe, thanks, I agree.
I have changed this to a meta. I have also created a child issue, Novice level, to fix all the instances in the update related XML fixtures. That will fix a majority of these.