Problem/Motivation

In #2719721: BreadcrumbBuilder::applies() mismatch with cacheability metadata we added an optional second parameter with the intent to make it mandatory. In the next major version, this requires we update the signature and implementations to always expect a $cacheable_metadata.

Steps to reproduce

/

Proposed resolution

Adjust API according to deprecation policy.

Remaining tasks

Adjust API according to deprecation policy.

User interface changes

/

API changes

Finalize new function parameter.

Data model changes

/

Release notes snippet

/

Issue fork drupal-3459277

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kristiaanvandeneynde created an issue. See original summary.

abarrio made their first commit to this issue’s fork.

abarrio opened merge request !8690

abarrio’s picture

abarrio
Primary language Spanish
Location Seville
CreditAttribution: abarrio at 1xINTERNET commented
Status: Active » Needs review

Created merge request with needed changes.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Postponed

So believe this will actually be postponed until a 12.x branch is started.

Didn’t dig deep but see a unit failure. Was an instance missed that should be added to the deprecation ticket?

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: kristiaanvandeneynde at Factorial GmbH commented

Yeah it was a bit premature to start on this one already, the issue is merely here for when we start working on D12. hence the tag.