Problem/Motivation

In #2719721: BreadcrumbBuilder::applies() mismatch with cacheability metadata we added an optional second parameter with the intent to make it mandatory. In the next major version, this requires we update the signature and implementations to always expect a $cacheable_metadata.

Steps to reproduce

/

Proposed resolution

Adjust API according to deprecation policy.

Remaining tasks

Adjust API according to deprecation policy.

User interface changes

/

API changes

Finalize new function parameter.

Data model changes

/

Release notes snippet

/

Issue fork drupal-3459277

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kristiaanvandeneynde created an issue. See original summary.

abarrio made their first commit to this issue’s fork.

abarrio opened merge request !8690

abarrio’s picture

abarrio
Primary language Spanish
Location Seville
commented
Status: Active » Needs review

Created merge request with needed changes.

smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed

So believe this will actually be postponed until a 12.x branch is started.

Didn’t dig deep but see a unit failure. Was an instance missed that should be added to the deprecation ticket?

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Yeah it was a bit premature to start on this one already, the issue is merely here for when we start working on D12. hence the tag.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

andypost made their first commit to this issue’s fork.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed » Needs review
Parent issue: #2719721: BreadcrumbBuilder::applies() mismatch with cacheability metadata » #3553503: [meta] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules from Drupal 12
Related issues: +#2719721: BreadcrumbBuilder::applies() mismatch with cacheability metadata

rebased as the time has come

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

All instances appear to be addressed here!

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Deprecation Removal
smustgrave’s picture

smustgrave commented
Parent issue: #3553503: [meta] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules from Drupal 12 » #3570920: [meta] Adjust parameters in interfaces

catch closed merge request !8690

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed c62b2574 on main 
    task: #3459277 Enforce second parameter in BreadcrumbBuilderInterface::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.