GenerateThemeTest::testContribStarterkitDevSnapshotWithGitNotInstalled fails on sqlite

Ahh,, even I tried to replicate on local for me test pass on local , not sure may be missing any step at my end

This appeared to break in the upgrade to Symfony 7.1, but not entirely sure why. Note also that this test only runs on SQLite anyway, it is skipped on other database engines.

What I think is happening is the updated PATH env var is not taking effect, and instead the current PATH is being searched for the git binary. The attempt in the MR succeeds here locally but then fails later, let's see what happens on CI at least.

Actually I'm not sure how this test worked before, unless git was not available in the environment perhaps?

The fake git is set up and tested, but then the second Process object doesn't override $PATH, so how/why would it find the fake git by that point?

Oh I see, $env is passed into the second Process. But the first Process doesn't technically need it because it is executed from the context of PHP and PATH (or COLUMNS) don't come into play, so I pushed a simplification that works locally.

So, this test *does* fail on all database drivers, but *only* if SQLite 3.45 is available. On Drupal CI, the MySQL and Postgres tests run in a different PHP container that only has SQLite 3.40, and so the tests are skipped.

However, for the purposes of this test at least, it seems it's not necessary to check the SQLite version - and I'm wondering if that's the case for any of the build tests.

Most tests run on php-8.3-apache:

    _TARGET_PHP: "8.3"

but SQLite changes this:

'PHP 8.3 SQLite 3.45':
  <<: [ *default-stage, *run-on-mr ]
  variables:
    _TARGET_PHP: "8.3-ubuntu"

And then you can see the difference by checking versions in the containers directly:

$ docker run drupalci/php-8.3-apache:production php -r "print (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];"
3.40.1

$ docker run drupalci/php-8.3-ubuntu-apache:production php -r "print (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];"
3.45.1

Faced the same error but on Mysql and PHP 8.4alpha2 in #3427903-22: [META] Make Drupal 10/11 compatible with PHP 8.4

FYI added changes from MR !8746 allowed to pass tests on 8.4!

EDIT fixed link

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Changes looks ready for RTBC but somehow I can't trigger sqlite testing job

I think maybe Dave needs to trigger it? "You are not authorized to trigger this manual job."

I think this is Major if not Critical, since this issue has been systematically failing all SQLite test runs for quite some time.

Looking at Issue Priority docs, https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-...

Critical bugs include those that:

[...]
Cause tests to fail in HEAD on the automated testing platform for any supported environment (including random failures), since this blocks all other work.
[...]

I think it good to go to fix immediate bug and continue (for 11.x) with #3461006: Use Ubuntu images in all CI environments for core

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!