Hello and welcome to this Drupal 11 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 11 upgrade of their sites are also welcome.
➤ Happens every Monday at 20:00 CEST (currently 18:00 UTC).
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3453752`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

Fathima Asmat Fathima here from London, uk :wave:  (edited)
hestenet (he/him) Tim from the DA, in Portland, OR
Björn Brala (bbrala) Björn
mikelutz (he/him) Hey all.
berdir hi, Berdir/Sascha
smustgrave Hello
VladimirAus Vladimir :kangaroo: :wave:
guptahemant Hello everyone,  Hemant from India, Reading through threads to understand the latest progress towards D11 readiness
Kristen Pol (she/her) Kristen, catching up

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

Fathima Asmat This may have been already discussed so apologies in advance. Where is Drupal rector with D11 readiness?
Fathima Asmat Can we do anything about detecting deprecated hook with upgrade status module for D11 readiness.  There is this issue which I think was started for D10,#3142908: Add ability to detect deprecated hooks
smustgrave Not a thread but what’s the link to the acquia page about the status of modules to D11?
Gábor Hojtsy (he/him) I need to go but keep the topics going as needed :)
Kristen Pol (she/her) I’ll add a thread about PUWG progress

2️⃣ Celebrations :tada:

Fathima Asmat I think this is one to celebrate, Drupal 11 will release with Symfony 7[#3432860] is closed and merged  (edited)
Gábor Hojtsy (he/him) Yeah that has been in a while, but no reason not to celebrate 🙂
Fathima Asmat Yeah, catching up with D11 bits quite recently only :smile:
VladimirAus D11 release:https://www.drupal.org/project/shorthand/releases/4.0.13
Kristen Pol (she/her) The #project-update-working-group had our first meeting to start getting organized :tada:

3️⃣ Where is Drupal rector with D11 readiness?

Gábor Hojtsy (he/him) @Fathima Asmat raised this
Gábor Hojtsy (he/him) https://www.drupal.org/project/rector is the project
Gábor Hojtsy (he/him) it has various drupal 10 to 11 rules
Björn Brala (bbrala) It has quite a few, we also enabled symfony ones to make sure that is compatible.There are quite a few changes not implemented, but everything that was detected more than a handfull times has either been implemented as fix or decide to be too complex.So, still changes to make it easier for contrib, but most high impact (detecable) issues are done.
berdir I think there's the data providers, I didn't entirely grok your replies there, but I think it would at least need something to make sure those existing conversions run? (it is, afaik also not discovered yet) https://drupal.slack.com/archives/C03L6441E1W/p1717530687990169
Björn Brala (bbrala) This could work through phpunit.
Björn Brala (bbrala) But think that is a phpunit100 rule
Björn Brala (bbrala) Let me check
Björn Brala (bbrala) image.png 
Björn Brala (bbrala) I'm a little scared to enable full phpunit 10 rules, there is quite a few
berdir yeah. just at first glance I see the prophecy thing, that caused a lot of confusion alrady in the d9 => d10 update as core does in fact add that already
Björn Brala (bbrala) https://github.com/rectorphp/rector-phpunit/blob/main/config/sets/phpuni...
Björn Brala (bbrala) thats the current full list for phpunit 10
Björn Brala (bbrala) just kinda scared if its all BC or it contains breaking changes
Björn Brala (bbrala) we could enable only the rules that we want, like static/public dataproviders for example
berdir I think that would be a good start. so far, the only thing I had to adjust were data providers
Björn Brala (bbrala) I can add those for next run, np.
berdir https://git.drupalcode.org/search?group_id=2&repository_ref=&scope=blobs...
Björn Brala (bbrala) ppearantly it doesnt trigger a deprecation error
Björn Brala (bbrala) https://dev.acquia.com/drupal11/deprecation_status/errors?category=PHPUn...
Björn Brala (bbrala) yay for runtime stuff?
Björn Brala (bbrala) So basically:https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_...  https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_...
berdir no, it's not discovered yet
Björn Brala (bbrala) Wonder if we should add also then:Call to deprecated method setMethods() of class PHPUnit​\​Framework​\​MockObject​\​MockBuilder: https://github.com/sebastianbergmann/phpunit/pull/3687
Björn Brala (bbrala) (https://dev.acquia.com/drupal11/deprecation_status/errors?category=PHPUn...)
berdir I guess that should be fine, apparently just a method rename?
Björn Brala (bbrala) yeah it is
Björn Brala (bbrala) https://github.com/palantirnet/drupal-rector/pull/307Unfortunately the docgen package keeps breaking head... :disappointed:
berdir as per berdir.so if anything goes wrong, you can just blame it on me, I see... ;)
Björn Brala (bbrala) Hahaha :smile:
Björn Brala (bbrala) Now I just need approval for that one from someone... @mglaman? :sweat_smile: ❤️
mglaman StaticDataProviderClassMethodRector fml over so much wasted time w/o this
Björn Brala (bbrala) Always check rector first xD
Björn Brala (bbrala) https://drupal.slack.com/archives/C0100FHELV9/p1718047152357289
Björn Brala (bbrala) Should run next run this saturday
Gábor Hojtsy (he/him) Yay! I should work on the upgrade status queue a bit later this week to get some stuff in 🙂
Gábor Hojtsy (he/him) then fold some of the applicable things to deprecation status too
Björn Brala (bbrala) awesome 🙂

4️⃣ Detecting deprecated hooks with upgrade status module for Drupal 11 readiness

Gábor Hojtsy (he/him) Also raised by @Fathima Asmat
Gábor Hojtsy (he/him) Issue is at[#3142908]
Gábor Hojtsy (he/him) Are there specific hooks you are looking to get covered? The best we can do is to match some naming patterns, but probably can't get too close to perfect.
Fathima Asmat Hooks like file_validate_* for example, https://api.drupal.org/api/drupal/core%21modules%21file%21file.module/fu...
Björn Brala (bbrala) @mglaman and @Kingdutch did something around that I remember.Not sure if that got merged into phpstan.
berdir file_validate_* stuff isn't actually a hook, but configured callbacks, so probably tricky to discover. deprecated calls to file_validate() themself are discovered. (edited)
Kingdutch https://github.com/mglaman/phpstan-drupal/pull/634 has been merged into PHPStan Drupal about 7 months ago (didn't realise it's been that long :sweat_smile: )So in theory if you add @deprecated to a hook implementation in module.api.php then PHPStan Drupal should start complaining.If you find that's not the case then there's a bug and we'll have to investigate :smile:
Kingdutch Ooh right, an "opt-out" was added in https://github.com/mglaman/phpstan-drupal/pull/641However, depending on how you configure PHPStan Drupal, if you don't include the bleedingEdge.neon file that it now ships then the hook deprecation checking is no longer enabled :disappointed:
mglaman Yeah, apparently those files were crashing for people :/
mglaman Maybe we can just load ones found in core only
mglaman Two flags: one for core one for contrib, easier to opt in
Kingdutch Yeah the idealist in me feels like contrib should fix their .api.php files to be valid PHP :upside_down_face: but I see how that's not necessarily feasible.I think the only oopsie from PHPStan Drupal's side is that it was broadcast as opt-out (i.e. works by default) whereas the feature is now explicitly opt-in (i.e. nothing happens unless you do something). Which is why the above issue is still open in upgrade_status and why I'm likely also no longer using this in Open Social projects where I thought I still had it :see_no_evil:
Kingdutch If we can update documentation to show how to opt-in, then keeping a single flag for now may be enough. If any of the ~700 modules we download for Open Social contain bad .api.php files then I'd be pretty happy to file a bugfix to them :grimacing: But not sure if that solves Gàbor's problem as well. (edited)
mglaman yeah docs were out of date do to quick fix.allowing opting into core api.php solves upgrade statusallowing opting into contrib = the current flag basically
mglaman I’ll open an issue quick and link here
mglaman https://github.com/mglaman/phpstan-drupal/issues/770
mglaman I think this summarizes the needs
Kingdutch Looks good, added two questions :smile:

5️⃣ Where can we track module readiness to Drupal 11? (edited) 

Gábor Hojtsy (he/him) Raised by @smustgrave
Gábor Hojtsy (he/him) https://dev.acquia.com/drupal11/deprecation_status/projects
Björn Brala (bbrala) suggest we pin/add it to the channel tlinks
Gábor Hojtsy (he/him) Done

6️⃣ Thanks all for coming! See you next week!

Participants:

Fathima Asmat, Gábor Hojtsy, VladimirAus, Kristen Pol, bbrala, Berdir, mglaman, Kingdutch

Related Issues:

#3142908, #3432860

Comments

Gábor Hojtsy created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

mikelutz credited bbrala.

mikelutz credited Berdir.

mikelutz credited Kingdutch.

mikelutz credited Kristen Pol.

mikelutz credited mglaman.

mikelutz credited VladimirAus.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Issue summary: View changes
Status: Fixed » Needs review
Related issues: +#3142908: Add ability to detect deprecated hooks, +#3432860: Update to Symfony 7.0

mikelutz credited fathima.asmat.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Verified threads were captured and active participants were credited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.