Problem/Motivation

Drupal 11 will release on Symfony 7. All prerequisites have landed so this is the issue where the upgrade will take place.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3432860

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Update to Symfony 7.0 » [PP-1] Update to Symfony 7.0
Status: Active » Postponed
Related issues: +#3413268: Add PHP 8.3 requirement to Drupal 11.0.x

Symfony 7 requires PHP 8.2, 11.x currently still allows PHP 8.1, so postponing for now on #3413268: Add PHP 8.3 requirement to Drupal 11.0.x

longwave opened merge request !7245

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [PP-1] Update to Symfony 7.0 » Update to Symfony 7.0
Status: Postponed » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Running into lots of "Deprecated NULL placeholder value for key (%name) in: "%name: this field cannot hold more than @count values.". This will throw a PHP error in drupal:11.0.0."

See #3431200: FieldItemList::getConstraints() incorrectly sets $maxMessage as TranslatableMarkup and #3054535-37: Discuss whether to decouple from Symfony Validator

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Pushed a single commit from #3431200: FieldItemList::getConstraints() incorrectly sets $maxMessage as TranslatableMarkup which might be enough to get tests passing here.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Second attempt where we only translate messages if we need to; in the case of NULL we use the default validation message.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

This is the bare minimum to get us to Symfony 7 - we should solve the validation messages issue across core in #3431200: FieldItemList::getConstraints() incorrectly sets $maxMessage as TranslatableMarkup.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Happy with doing #3431200: FieldItemList::getConstraints() incorrectly sets $maxMessage as TranslatableMarkup separately and after this lands, updating will make 11.x a much better testing target for contrib.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a65bbd5 and pushed to 11.x. Thanks!

  • alexpott committed a65bbd5d on 11.x 
    Issue #3432860 by longwave, catch: Update to Symfony 7.0

longwave closed merge request !7245

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.