Problem/Motivation

While working on issue #3328095, I noticed that css checks fail because of cqw unit which is one of the new container query units.

Container queries are now supported in all major browser and I believe we should add the units to unit-allowed-list stylelint rule.

The container query length units are:

  • cqw: 1% of a query container's width
  • cqh: 1% of a query container's height
  • cqi: 1% of a query container's inline size
  • cqb: 1% of a query container's block size
  • cqmin: The smaller value of either cqi or cqb
  • cqmax: The larger value of either cqi or cqb

Browser support reference:
https://developer.mozilla.org/en-US/docs/Web/CSS/@container#browser_compatibility

Steps to reproduce

Proposed resolution

Add "cqw", "cqh", "cqi", "cqb", "cqmin", "cqmax" units to unit-allowed-list rule.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3447942

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Redwan Jamous created an issue. See original summary.

Redwan Jamous opened merge request !8116

redwan jamous’s picture

redwan jamous commented
Status: Active » Needs review

ahsannazir made their first commit to this issue’s fork.

ahsannazir’s picture

ahsannazir commented

The pipeline is still failing for the MR. Not sure why it is failing. 

Drupal\Tests\file\Functional\DownloadTest::testPrivateFileTransferWithoutPageCache
    Correctly denied access to a file when file_test sets the header to -1.
    Failed asserting that 200 is identical to 403.
    
    /builds/issue/drupal-3447942/core/modules/file/tests/src/Functional/DownloadTest.php:138
    /builds/issue/drupal-3447942/core/modules/file/tests/src/Functional/DownloadTest.php:76
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward

hritick’s picture

hritick commented

the changes in the merge request works as per expectation.
RTBC+1

Thanks and regards.

nod_ closed merge request !8116

  • nod_ committed ebc2c6c1 on 10.3.x 
    Issue #3447942 by Redwan Jamous, ahsannazir, smustgrave: Update...

  • nod_ committed cec5e435 on 10.4.x 
    Issue #3447942 by Redwan Jamous, ahsannazir, smustgrave: Update...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed f847622356 to 11.x and 0f0ab3b932 to 11.0.x and cec5e4353e to 10.4.x and ebc2c6c187 to 10.3.x. Thanks!

  • nod_ committed 0f0ab3b9 on 11.0.x 
    Issue #3447942 by Redwan Jamous, ahsannazir, smustgrave: Update...

  • nod_ committed f8476223 on 11.x 
    Issue #3447942 by Redwan Jamous, ahsannazir, smustgrave: Update...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.