Problem/Motivation
If I add something like this to my site and run the stylelint, I get an error (unknown unit)
.class {
height: 100dvh;
}
Steps to reproduce
Described above.
Here's an explainer about these units: https://dev.to/frehner/css-vh-dvh-lvh-svh-and-vw-units-27k4
Proposed resolution
Add the following to the allow units list: dvh, svh, lvh, dvw, svw, lvw since they are all valid CSS units (especially in an era of mobile design).
Remaining tasks
Create MR
User interface changes
None
Introduced terminology
None
API changes
None
Data model changes
None
Release notes snippet
dvh, svh, lvh, dvw, svw, lvw are now allowed units in our .stylelintrc.json config.
Issue fork drupal-3569022
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3569022-add-dvh-svh
changes, plain diff MR !14459
Comments
Comment #2
markconroy commentedComment #3
markconroy commentedComment #5
markconroy commentedComment #6
cilefen commentedIn #3447942: Update stylelint rule unit-allowed-list to include container query units, this was the CSS component, so I'm just moving it there and updating the category to match. I don't see a reason not to do this.
Comment #9
catchCommitted/pushed to main and 11.x, thanks!