• Leftover code from a feature that isn't planned to be part of this module, in which case it should be removed.
CommentFileSizeAuthor
#7 e5073abe81daa70d1ff9ce163df0a9a4.png107.13 KBfinnsky

Issue fork drupal-3443461

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Project: Navigation » Drupal core
Version: 1.x-dev » 11.x-dev
Component: Code » navigation.module
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Issue tags: +Portland2024

Gauravvvv made their first commit to this issue’s fork.

Gauravvvv opened merge request !7955

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
finnsky’s picture

finnsky commented
Status: Needs review » Needs work
StatusFileSize
new e5073abe81daa70d1ff9ce163df0a9a4.png107.13 KB

1. This fix contains some css which displays Back button on desktop.

back button

2. This escapeAdmin js can be removed at all. We don't have this functional now. It was added initially when we had breadcrumbs.

finnsky’s picture

finnsky commented
Title: escapeAdmin.js functionality requires atttribute that is not present » escapeAdmin.js functionality should be removed(it not used anymore)
Issue summary: View changes

Mithun S made their first commit to this issue’s fork.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
finnsky’s picture

finnsky commented
Status: Needs review » Needs work

Attribute still added in twig

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
finnsky’s picture

finnsky commented
Status: Needs review » Reviewed & tested by the community

Thank you! Looks good!

nod_ closed merge request !7955

  • nod_ committed 4db4f4b4 on 10.3.x 
    Issue #3443461 by Gauravvvv, Mithun S, finnsky, ckrina: escapeAdmin.js...

  • nod_ committed 5d9fa4ef on 10.4.x 
    Issue #3443461 by Gauravvvv, Mithun S, finnsky, ckrina: escapeAdmin.js...

  • nod_ committed 53c88323 on 11.0.x 
    Issue #3443461 by Gauravvvv, Mithun S, finnsky, ckrina: escapeAdmin.js...

  • nod_ committed 79980296 on 11.x 
    Issue #3443461 by Gauravvvv, Mithun S, finnsky, ckrina: escapeAdmin.js...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 799802965e to 11.x and 53c88323af to 11.0.x and 5d9fa4ef0d to 10.4.x and 4db4f4b4b4 to 10.3.x. Thanks!

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

Follow-up #3446699: Implement a feature similar to the "Go Back" / escapeAdmin.js.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.