Problem/Motivation

PhpUnit 10.5.18 Deprecated support for string array keys in data sets returned by data provider methods that do not match the parameter names: https://github.com/sebastianbergmann/phpunit/blob/10.5/ChangeLog-10.5.md...

See https://github.com/sebastianbergmann/phpunit/pull/5812.

Proposed resolution

Ensure all dataproviders that return associate arrays have the keys reflecting the name of the argument that uses each, in Unit tests.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3441718

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mondrake created an issue. See original summary.

mondrake’s picture

Assigned: mondrake » Unassigned
Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Lot of changes but seems pretty straight forward. Assuming when we update these will be caught automatically.

mondrake’s picture

#4 : test failures are visible as deprecation errors in #3417066: Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency testing.

  • longwave committed ea9a0f90 on 10.3.x
    Issue #3441718 by mondrake: Fix string array keys in data sets returned...

  • longwave committed f4e9c070 on 11.x
    Issue #3441718 by mondrake: Fix string array keys in data sets returned...
longwave’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed f4e9c07001 to 11.x and ea9a0f908a to 10.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.