
Problem/Motivation
PhpUnit 10.5.18 Deprecated support for string array keys in data sets returned by data provider methods that do not match the parameter names: https://github.com/sebastianbergmann/phpunit/blob/10.5/ChangeLog-10.5.md...
See https://github.com/sebastianbergmann/phpunit/pull/5812.
Proposed resolution
Ensure all dataproviders that return associate arrays have the keys reflecting the name of the argument that uses each, in Unit tests.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3441718
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3441718-fix-string-array
changes, plain diff MR !7568
Comments
Comment #3
mondrakeComment #4
smustgrave CreditAttribution: smustgrave at Mobomo commentedLot of changes but seems pretty straight forward. Assuming when we update these will be caught automatically.
Comment #5
mondrake#4 : test failures are visible as deprecation errors in #3417066: Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency testing.
Comment #8
longwaveCommitted and pushed f4e9c07001 to 11.x and ea9a0f908a to 10.3.x. Thanks!