1.use claro as frontend theme.
2.enable the layout builder module .
3.use layout build module for any block type .
4.Add a long title for any section .
There should be word-break as it is in olivero theme for body .
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Screenshot from 2024-04-16 17-51-40.png | 20.65 KB | sourojeetpaul |
| #6 | Screenshot from 2024-04-16 17-52-05.png | 16.14 KB | sourojeetpaul |
| #3 | after applying css.png | 262.11 KB | sandeep sanwale |
| claro theme modal.png | 284.22 KB | sandeep sanwale |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !7493
Comments
Comment #3
sandeep sanwale commentedAdded the css so that close icon does not overlap the title.
Comment #4
smustgrave commentedMR appears to have issues.
But not sure we want to add that css to the global body selector.
Comment #5
sandeep sanwale commentedThe MR issue has been resolved . I have added the css in body selector because in the olivero theme also this css added in body selector.Please review .
Comment #6
sourojeetpaul commentedHello @Sandeep, I've successfully reproduced the issue you were talking about, and the patch provided by you also got applied successfully. After applying the patch the issue is resolved now and there is a breathing space between the section title and the close button. So moving it to RTBC++.
Attaching screenshots before and after applying the patch for reference!
Comment #7
gauravvvv commentedI have a question? Why're we using Claro as a frontend theme?
Claro is an admin theme. Do we support using Claro as frontend theme?
FYI: This is working fine with Olivero frontend theme.
Comment #8
sourojeetpaul commentedHi, @Gauravvvv
As far as I know there is no hard and fast rules regarding the usage of theme. Its completely subjective. Though I've also seen Claro being used as admin theme predominantly, but one might choose to opt it for their frontend theme based on their needs. So I think it'll be better to address the issue and fix it, no matter if someone is using it as frontend theme or admin theme, we should fix the flaws in the respective theme!
Comment #9
nod_We have the same rule in olivero, What's missing here would be to remove the hyphen rules in other places it is used in claro like the pcss files: media-library, vertical-tabs, form--managed-file, details,
Comment #10
gauravvvv commentedComment #11
nod_comment in mr
Comment #12
gauravvvv commentedFeedback addressed.
Comment #13
nod_we can still remove the hyphens: auto from the managed file css, we just need to keep break-word since it's different from the default
Comment #14
meghasharma commentedComment #15
meghasharma commentedHello @here, Commit is successfully removing the hyphens: auto from css & .pcss.css files. Looks good to me., So moving it to RTBC++. Thanks!.
Comment #18
nod_Committed 98b2153 and pushed to 11.x. Thanks!
Comment #21
lars.stiebenz commented"body {hyphens: auto}" is in 10.3.x/11.x and git blame is pointing to this issue.
Can someone check if the commits were merged correctly?
Comment #22
kevinb623 commentedEchoing Lars' comment #21.
We have had feedback from our editors regarding hyphens appearing in editor textareas. This is causing confusion between legit hyphen usage and those inserted by the CSS.
Comment #23
trackleft2I am here to second kevinb623.
Now that CKEditor5 is no longer in an iframe, we must be extremely careful when editing any styles in our themes that may affect the editor.