Problem/Motivation

In #3325167: Revisit the redirect to 'add block' form in the 'add block content' form this method was added with public visibility while the parent has protected. This broke Panels #3413891: Panels IPE block content edit form not loading with Drupal 10.2

Proposed resolution

Change it to protected

Issue fork drupal-3424751

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !6836

acbramley’s picture

acbramley commented
Status: Active » Needs review
acbramley’s picture

acbramley commented
Issue summary: View changes
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

This seems straightforward.

Unless I'm missing something, I don't think this could cause a BC break; anything in contrib that overrides this method is either keeping it protected (and which would be fixed by this), or have made it public, which should continue working after this is committed.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 11.x and backported to 10.3.x and 10.2.x - thanks all

  • larowlan committed db5e5c12 on 10.2.x 
    Issue #3424751 by acbramley: BlockContentForm::actions is incorrectly...

  • larowlan committed bed76898 on 10.3.x 
    Issue #3424751 by acbramley: BlockContentForm::actions is incorrectly...

  • larowlan committed 8e3e867b on 11.x 
    Issue #3424751 by acbramley: BlockContentForm::actions is incorrectly...

larowlan closed merge request !6836

acbramley’s picture

acbramley commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.