Problem/Motivation

Remove the Tour module

Steps to reproduce

Proposed resolution

Remaining tasks

  • The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-Tour. (For example, the CR for removing HAL)
  • Tag this issue 'Needs release note.'
  • Remove the extension ;-).
  • Remove references from core/phpstan-baseline.neon.
  • Remove any spelling words specific to the extension from the dictionary
  • Check for references in @todo.
  • Handle migration tests.
    • In all the functional tests in migrate_drupal_ui make sure that Tour is not installed. Tour should also be removed from the methods getAvailablePaths() and moved to getMissingPaths() in the tests using those methods.

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3422600

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Postponed
quietone’s picture

quietone commented
Issue summary: View changes
Status: Postponed » Active

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !6799

smustgrave’s picture

smustgrave commented

Fingers crossed!

I'm wondering if it makes sense to close #3405660: Remove tour from themes and just do the work here. The theme ticket is blocked by this and pretty sure without the theme code this MR would fail too.

smustgrave’s picture

smustgrave commented
Status: Active » Postponed

Bummer seems tour is in some database fixtures and guess need #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x done first. Also discovered #3424208: Remove tour from language.module

quietone credited catch.

quietone credited larowlan.

quietone credited lauriii.

quietone credited Wim Leers.

quietone’s picture

quietone commented

I've closed #3405660: Remove tour from themes as a duplicate and am adding credit.

smustgrave’s picture

smustgrave commented

#3424208: Remove tour from language.module moved this to contrib and copied over the removal hook from the language module to this ticket. Not sure correct status but leaving in postponed as believe the fixtures need updating still.

Spokje made their first commit to this issue’s fork.

spokje’s picture

spokje
Primary language Dutch
commented

Rebased after #3399746: Add declare(strict_types=1) to all Functional tests landed.

Maintainer of Contrib tour module might want to grab the change done on Functional tests and add them to the contrib module.

smustgrave’s picture

smustgrave commented

So good news when applying the changes @quietone did on #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x I get the same errors so tells me removal was good.

smustgrave closed merge request !6799

smustgrave opened merge request !7609

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Needs review
smustgrave’s picture

smustgrave commented

All green

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Very straightforward removal now, looks ready to go.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1c66f7e and pushed to 11.x. Thanks!

We need an issue to deprecate shepherd.js in Drupal 10.3.x ... and an issue to include it in the contrib module.

  • alexpott committed 1c66f7ec on 11.x 
    Issue #3422600 by smustgrave, Spokje, quietone, catch, larowlan, lauriii...

smustgrave closed merge request !7609

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.