Problem/Motivation

Similar to #2885098: Node RSS Views plugin causes wrong entity_view output to be cached the RSS plugin in the comment module suffers from the same issue of cache pollution.

Steps to reproduce

1. Create a comments view with two displays; one Page display and one Feed display.
2. Configure both displays to show comments using the same view mode
3. Ensure render caching is enabled
4. Rebuild site caches
5. Open incognito(private) browser window
6. Visit the Feed display
7. Visit the Page display

The page display outputs the comments as concatenated field markup instead of using the comment template.

Proposed resolution

See #2885098: Node RSS Views plugin causes wrong entity_view output to be cached - add a cache key to the plugin
Add tests

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3418181

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Related issues: +#2885098: Node RSS Views plugin causes wrong entity_view output to be cached

andypost made their first commit to this issue’s fork.

andypost opened merge request !6397

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs work

Needs work for test and view

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.