Problem/Motivation

In #3392616-5: Update to Symfony 6.4 we've found out that the Symfony\Component\DependencyInjection\ContainerAwareTrait and Symfony\Component\DependencyInjection\ContainerAwareInterface are being deprecated in Symfony 6.4.

Although we can't get rid off all implementations and will need to fork those into core, we want to get rid of as many usage as possible. We have figured out ways to remove all uses so this is deprecated in Drupal 10 and will not be supported in Drupal 11.

This issue exists as a META to group all removal of usage.

Steps to reproduce

Proposed resolution

Remaining tasks

#3416354: Inject services into LoggerChannelFactory
#3431362: Remove support for ContainerAwareInterface

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Fixed

All children fixed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.2.x-dev

The child issues were resolved in 10.2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 10.2.x-dev » 11.x-dev
Status: Closed (fixed) » Active

Forgot this existed. This would be a better parent for many of the child issues I am creating than #3397522: Fork Symfony's ContainerAwareTrait and ContainerAwareInterface into core, so reopening.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Probably \Drupal\Core\DependencyInjection\ClassResolver::getInstanceFromDefinition() still should use deprecated interface for BC

    if ($instance instanceof ContainerAwareInterface) {
      $instance->setContainer($this->container);
    }
andypost’s picture

andypost
he/him
Primary language Russian
commented

one more done #3420215: Remove ContainerAwareTrait from session middleware

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: #3392616: Update to Symfony 6.4 » #3394694: [Meta] Symfony 7 compatibility
Related issues: +#3392616: Update to Symfony 6.4, +#3427741: Notify downstream users that ContainerAware is going away

Reparenting as the existing parent is closed.

#3427741: Notify downstream users that ContainerAware is going away proposes deprecating the code mentioned in #6.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

What else is left here? This the only issue left from the parent's issue summary. Also #3431362: Remove support for ContainerAwareInterface is linked from the parent, how are the two related?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes

Reparented the final removal under this issue, updated the IS as we can actually remove all implementations here.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Reviewed & tested by the community

As fixed #3431362: Remove support for ContainerAwareInterface

The remaining one is good enough without meta - #3416354: Inject services into LoggerChannelFactory

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Just committed #3416354: Inject services into LoggerChannelFactory too. Nice to get all these done!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.