Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
base system
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Oct 2023 at 17:53 UTC
Updated:
30 Apr 2024 at 06:04 UTC
Jump to comment: Most recent
Comments
Comment #2
bradjones1I'm going to bump this to major since there is a kinda time-sensitive request in the Symfony IS for dependent frameworks to determine if there are particular types that will be hugely problematic. There are instructions, and I think this should be easy enough to do in GitLab CI.
Comment #3
bradjones1Closing as a duplicate of #3392616: Update to Symfony 6.4
Comment #4
bradjones1Not a duplicate.
Comment #5
quietone commentedComment #6
longwaveThe following dependencies need to declare Symfony 7 compatibility:
asm89/stack-cors- pull request at https://github.com/asm89/stack-cors/pull/104behat/mink- support is in master but not a tagged releasebehat/mink-browserkit-drivermglaman/phpstan-drupalComment #7
quietone commented@longwave, thanks.
I've moved the list of upstream changes to the Issue Summary and added a link for the behat/mink-browserkit-driver issue.
Comment #8
longwaveComment #9
mglamanMerged https://github.com/mglaman/phpstan-drupal/pull/639 – I just want to wait a few days to release phpstan-drupal as I cut 1.2.3 this morning, right before the issue was filed.
Comment #10
longwaveI have a pipeline running on Symfony 7 over in a test issue, where almost all the tests are passing with a handful of changes to core - need to break those out into separate issues so we can decide what to do with them in 10.x and 11.x but overall it's looking quite good to me: https://git.drupalcode.org/project/drupal/-/pipelines/49497/test_report
Comment #11
andypostUpdated IS a bit with current state
Comment #12
andyposthttps://github.com/asm89/stack-cors/releases/tag/v2.2.0 is out as well as SF 6.4.0/7.0.0
Only
behat/mink*is not ready (as always)Comment #13
andypostordering to IS points
Comment #14
andypostmink merged changes to master so only tagged releases left
Comment #15
andypostasm89/stack-corswill be included in #3404694: Update dependencies for Drupal 10.2mglaman/phpstan-drupalneeds bump constraints/1.2.1/1.2.4Comment #16
andypostSF7 compatibility will require composer 2.7 https://github.com/composer/composer/issues/11741#issuecomment-1847572878
Comment #17
longwaveComment #18
longwaveComment #19
catchcomposer 2.6.6 apparently resolves https://github.com/composer/composer/issues/11741#issuecomment-1847572878 so we might be able to just update to that instead of waiting for 2.7.
Comment #20
andypostIt resolving conflict st least so let's upgrade
Comment #21
longwaveThe list of tasks is incomplete, there are more than those listed.
https://git.drupalcode.org/project/drupal/-/merge_requests/5388 is an old work in progress MR that has some more SF7 fixes in it.
Comment #22
andyposthttps://github.com/symfony/symfony/releases/tag/v7.0.3
Comment #23
andypostComposer released https://github.com/composer/composer/releases/tag/2.7.0
Comment #26
spokjeComment #27
spokjePushed a YOLO! commit to the MR, just with the updated dependencies, now that all external dependencies are SF7 ready.
As PHPStan shows (and @longwave already said in #21): The list of tasks is incomplete, there are more than those listed.
A lot of wheels are already in motion to get rid of the "last" SF6.4 issues, for Behat and friends there's an issue somewhere, and there are bound to be more issues floating around.
Comment #31
spokjeNew MR, either me or GitLab couldn't figure out a rebase on the previous one (yeah, prob me...).
Not much to see until #3407159: [11.x] Add void returns for Symfony 7 lands.
Comment #32
gábor hojtsy#3407159: [11.x] Add void returns for Symfony 7 is for the 11.x codebase only, so it cannot be committed right now. Are there any other changes to be made on "the 10.3.x branch" for Symfony 7 or none left?
Comment #33
longwaveSome of the ContainerAware removals will likely also be committed to 10.3.x as they will involve deprecations. It's hard to see the full picture without clearing the void returns and ContainerAware issues first, there may be more we need to do after that that also involve adding deprecations to 10.3.x.
Comment #34
catchRebased the MR.
Before the rebase:
88 errorsAfter the rebase:
62 errorsComment #35
spokjeRebased and bumped
symfony/*to 7.0.4.After the rebase:
58 errorsComment #36
spokjeRebased and bumped
symfony/*to 7.0.5.After the rebase:
58 errorsComment #37
longwaveOne existing issue reparented and three new child issues to handle Symfony Validator issues that are picked up here:
#3425150: Symfony deprecations in Constraint plugins
#3427737: Overwrite Symfony constraint properties in constructors instead of child properties
#3427738: Remove $context properties from ConstraintValidators
#3427739: Remove Drupal\Core\Field\InternalViolation shim
Comment #38
spokjeRebased.
PHPStan:
Found 23 errorsComment #39
longwaveWhoops, your push wasn't there when I started my own rebase, and then I repeated and overwrote your work, sorry!
Comment #40
spokjeNo worries, as long as the end result is less errors :)
Comment #41
longwaveRebase again following two more commits, down to 10 errors.
Comment #42
andypostneeds rebase/fixes
Comment #43
spokjeDown to 7 PHPStan errors
Comment #44
longwaveOpened #3427741: Notify downstream users that ContainerAware is going away which if accepted means #3397522: Fork Symfony's ContainerAwareTrait and ContainerAwareInterface into core is won't fix.
Comment #49
longwaveUrgh, that was no fun to figure out. See #3054535-37: Discuss whether to decouple from Symfony Validator for the backstory on 95a33fe4.
Comment #50
longwaveA green pipeline on Symfony 7!
Only a few BaseFieldDefinition tweaks needed, will open another issue to backport those; was surprised that translated constraint errors didn't break, but it appears we have test coverage and all is good.
Comment #51
longwaveRaised https://github.com/symfony/symfony/issues/54321 as there is a type error in Symfony that we currently work around here, unsure which way they will fix this.
Comment #52
longwavehttps://github.com/symfony/symfony/issues/54321 was fixed so once Symfony 7.0.6 is out we can revert the change around
Request::setFactory().Comment #53
andypostLast child issue can be marked fixed #3397519: [META] Reduce use of ContainerAware classes where possible as commited #3431362: Remove support for ContainerAwareInterface and remaining is no longer a blocker #3416354: Inject services into LoggerChannelFactory
Comment #54
andypostNo blockers, needs work for upgrade issue
Comment #56
mondrakeThink #3413268: Add PHP 8.3 requirement to Drupal 11.0.x needs to be done first as it will set PHP to 8.3 min.
Comment #57
spokjePHP 8.2 is the minimum for SF 7, so not really a hard blocker.
However the release of SF 7.0.6 is, if we want to prevent using workarounds (as said by @longwave in #52)
Comment #60
longwaveOpened #3432860: Update to Symfony 7.0 to actually do the update, we must do #3413268: Add PHP 8.3 requirement to Drupal 11.0.x first (no point going to PHP 8.2 in between as we decided on 8.3 already) and we have a Validator component problem to sort out as well which probably should be its own issue.
Comment #61
mondrakeOut there in #3417066: Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency there are still a lot of DebugClassloader deprecations for Symfony 7 typehints, see https://git.drupalcode.org/issue/drupal-3417066/-/pipelines/127550 and its test jobs.
For some reason #3417066: Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency seems to be stricter than current symfony-bridge in reporting deprecations triggered before the test start.
Example:
Comment #62
andypostMost of it should be fixed by related rector to prevent manual intervention, the scariest is how contrib will adopt it...
Comment #63
mondrakeFiled #3436255: Fix return typehinting for Compiler and EventSubscriber related classes for #61
Comment #65
longwave#3432860: Update to Symfony 7.0 landed, so we are all done here - thanks to everyone who contributed especially @Spokje for keeping on top of this.
Comment #67
quietone commented