Problem/Motivation

If SDC get stable status it should integrate into the core namespace. This issue is to decide where the Element\ComponentElement should go.

Proposed resolution

I propose we move the Element\ComponentElement to Render\Element\ComponentElement.

Remaining tasks

Create a merge request against this branch which is the meta issue for these changes.

Thank you!

Issue fork drupal-3365693

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bbrala created an issue. See original summary.

dieterholvoet’s picture

dieterholvoet commented
Component: theme system » single directory components

plopesc made their first commit to this issue’s fork.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Issue summary: View changes
Status: Active » Needs review

Created MR https://git.drupalcode.org/issue/drupal-3352256/-/merge_requests/14

ComponentElement class moved and tests are passing properly.

However, I'm not sure about how to deal with Component*Test classes. My first thought was to move them to Drupal\Tests\Core\Render\Element namespace. However I'm not sure whether all those tests should belong to that namespace. Also module tests are divided into Kernel/Functional/ etc namespaces, while the core namespace mentioned above doesn't. Moving tests there would imply to rename test classes or create the test type specific namespaces.

Any thought or guidance here would be much appreciated.

Thank you!

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Not sure this issue is suppose to cover the test moves, but if not going to mark.

As far as your question not sure I understand. But I think the tests will have to be separate if that's what you're asking.

So unit tests can go under Drupal\Tests\Core\Render\Element
Kernel tests under Drupal\KernelTests\Core\Render\Element;

Least that's how I've understood the core test folder structure.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Reviewed & tested by the community » Fixed

Merged!

I agree that the test placement presents unique challenges. Let's move this discussion to a test specific issue.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.