Problem/Motivation

The /admin/structure/display-modes/view page has multiple ways to add view modes. Some users were confused about what's the difference between the two options. This wasn't a major challenge but something along the lines of "Hmm, I'm not sure what's the difference between these two buttons, I'll try to click both of them to see how they are different", concluding that they probably do the same thing.

Proposed resolution

In usability testing, vast majority of users navigate to this page from "Manage Display" and "Manage Form Display". From this perspective, we could remove the buttons that are specific to an entity type after #2721727: Allow user to add display modes from respective field UI's. has been done.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

lauriii created an issue. See original summary.

vbouchet’s picture

Status: Active » Needs review
StatusFileSize
new2.26 KB

Removing the "Add view mode" local action seems not a valid option to me as in case an entity type does not have yet a display mode configured, it would become impossible to add a display mode for this entity type as not listed here.

As only removing the buttons specific is an option, please find a patch to do so.

I will search (and open a new issue if it does not exist yet) for the Form Modes UI which follows the exact same pattern.

vbouchet’s picture

StatusFileSize
new2.5 KB

Fix PHPCS feedback.

Status: Needs review » Needs work
vbouchet’s picture

Status: Needs work » Needs review
StatusFileSize
new4.65 KB

I forgot to update the functional test to remove the test using the "Add new %entity_type view mode" specific button. The test is already taking care of the generic "Add view mode" flow so no need to change anything on that front.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Think I agree with removing the sub buttons. Is an extra click to select the entity to add a view mode for but think that's acceptable. Applied patch #5 and verified buttons are gone.

Status: Reviewed & tested by the community » Needs work
vbouchet’s picture

Status: Needs work » Reviewed & tested by the community

Mark as "Reviewed & tested by the community" as the test is now passing again.

lauriii credited rkoller.

lauriii’s picture

Title: Duplicate "Add view mode" buttons » [PP-1] Duplicate "Add view mode" buttons
Issue summary: View changes
Status: Reviewed & tested by the community » Postponed

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.